feat(annotations): hide page steppers on small-medium widths #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanthai
force-pushed
the
hide-page-steppers-on-small
branch
from
a052b4c to
b34ba96
Compare
jstoffan
requested changes
Jun 14, 2022
|
Personally, it didn't seem too bad to me. The designer had tried to find various places to preserve screen width real estate. I'll double check with flesi |
|
@ivanthai, any word back from design/product on the necessity of this change after all the other space-saving measures are in place? |
|
Product confirmed they wanted this change and design confirmed we especially needed it on touch because there's not enough space between tap targets. on precise pointer (mouse) devices, there's an overflow menu that we can utilize if we want to add it back. Mobile needs it, but not so much desktop |
ivanthai
force-pushed
the
hide-page-steppers-on-small
branch
from
34bf024 to
ae0cb30
Compare
|
We are removing the page steppers <767px across all modalities |
jstoffan
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide pagination steppers on screen widths < 767px (medium).
https://zpl.io/dxDDLEp