build(deps): Upgrade Papaparse to 5.0.0 #1330
Conversation
src/lib/viewers/text/CSVViewer.js
Outdated
| this.startLoadTimer(); | ||
| const urlWithAuth = this.createContentUrlWithAuthParams(template); | ||
| Papa.parse(urlWithAuth, { | ||
| delimitersToGuess: [',', '\t'], |
There was a problem hiding this comment.
I've added the option delimitersToGuess which will restrict the delimiters to comma and tab which technically was all that we supported given that we support the extensions CSV and TSV. I could remove this option entirely, but then there is an issue with the auto-detection of delimiter for XSS.csv with the excessive ; as well as ,.
At the end of the day it feels like keeping the delimiters to what we support makes sense. Allowing users to hack the system by naming it csv but providing delimiters such as | or ; doesn't make all that much sense, imo.
Thoughts?
There was a problem hiding this comment.
Gotcha, so it sounds like we may need some new options to maintain consistency with the current experience. Should we update the value to [',', '\t', Papa.RECORD_SEP, Papa.UNIT_SEP] to retain support for the "true" delimiters mentioned in the docs?
There was a problem hiding this comment.
Changed version to 5.0.0 which doesn't contain the tweaks to the method which aims to guess the delimiter. Will follow up with Papaparse with the issue we're seeing
ConradJChan
changed the title
Tested against sanity folder in all browsers