Skip to content

Commit

Permalink
Fix: AnnotationPopover CSS to not hide popover svgs (#304)
Browse files Browse the repository at this point in the history
  • Loading branch information
Conrad Chan authored Nov 30, 2018
1 parent 4f0418e commit 83ca5b7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 18 deletions.
13 changes: 0 additions & 13 deletions src/AnnotationThread.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ class AnnotationThread extends EventEmitter {
// $FlowFixMe
this.renderAnnotationPopover = this.renderAnnotationPopover.bind(this);
// $FlowFixMe
this.handleBlur = this.handleBlur.bind(this);
// $FlowFixMe
this.onCommentClick = this.onCommentClick.bind(this);
// $FlowFixMe
this.save = this.save.bind(this);
Expand Down Expand Up @@ -453,7 +451,6 @@ class AnnotationThread extends EventEmitter {
}

this.element.addEventListener('click', this.renderAnnotationPopover);
this.element.addEventListener('blur', this.handleBlur);
}

/**
Expand All @@ -467,16 +464,6 @@ class AnnotationThread extends EventEmitter {
}

this.element.removeEventListener('click', this.renderAnnotationPopover);
this.element.removeEventListener('blur', this.handleBlur);
}

/**
* Called when the annotation element loses focus
*
* @return {void}
*/
handleBlur() {
this.toggleFlippedThreadEl();
}

/**
Expand Down
12 changes: 7 additions & 5 deletions src/components/AnnotationPopover/AnnotationPopover.scss
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,17 @@
}

.ba-popover-flipped {
path,
rect {
display: none;
}

.ba-popover-caret {
bottom: 0;
transform: rotate(180deg);
}

&.ba-point-annotation-marker {
path,
rect {
display: none;
}
}
}

// MOBILE & TABLET CSS
Expand Down

0 comments on commit 83ca5b7

Please sign in to comment.