Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6 removes hidden input named "utf8" to forms. #509

Closed
lcreid opened this issue Jan 25, 2019 · 0 comments
Closed

Rails 6 removes hidden input named "utf8" to forms. #509

lcreid opened this issue Jan 25, 2019 · 0 comments

Comments

@lcreid
Copy link
Contributor

lcreid commented Jan 25, 2019

Rails 6 removes the hidden input field named "utf8", which breaks all the tests. See rails/rails#32125.

A note about possible solutions: form_with changed the output of helpers compared to form_for, and testing for both quickly became very complicated. DRY solutions to supporting different expected strings quickly become hard to understand. Non-DRY solutions require maintenance of a lot of boilerplate code. We didn't find a good balance in the case of form_with.

Part of issue #503.

@lcreid lcreid changed the title Rails 6 adds hidden input named "utf8" to forms. Rails 6 removes hidden input named "utf8" to forms. Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant