Node 20 support #1550

MarcAstr0 · 2024-09-11T15:15:12Z

Description

Node.js 18 will reach EOL in April 2025.

This PR includes the necessary changes for Booster to run with the latest LTS release of Node.js (20), considering that Azure Functions has a GA support level for Node.js 20.

Changes

Update dependencies to work with Node.js 20.
Apply small changes to the Azure provider infrastructure package due to changes in the Terraform CDK.
Add an upgrade-v3.md doc listing breaking changes when upgrading from 2.x to 3.x.

Checks

Project Builds
Project passes tests and checks
Updated documentation accordingly

MarcAstr0 · 2024-09-11T15:15:37Z

/integration sha=047bf5a353965251172eba59bc5a3fc9e0b71947

what-the-diff · 2024-09-11T15:15:57Z

PR Summary

Adding a new support script
A new file named install-run-rush-pnpm.js has been added to help in the consistent installation of currently used npm package manager.
Improving existing scripts
Scripts install-run-rush.js and install-run-rushx.js have been updated, likely to support the efficient use of project dependencies.
Update to project specific package.json files
Extensive updates have been made across various components of the project including application-tester, cli, framework-common-helpers, framework-core, framework-integration-tests, framework-provider-aws-infrastructure, framework-provider-aws, framework-provider-azure-infrastructure, framework-provider-azure, framework-provider-local-infrastructure, framework-provider-local, framework-types, metadata-booster, and the tools/eslint-config. These changes indicate that package dependencies are updated or modified possibly to keep up with new features and patches provided by those dependencies.
Modification in project template & demo
Updates have been made to project files cli/src/templates/project/package-json.ts, cli/test/fixtures/mock_project/package.json, framework-integration-tests/integration/fixtures/cart-demo/package.json to replicate the new standards and changes in the project components' package.json files.
Update on Azure's Gateway infrastructure script
An update has been made to file framework-provider-azure-infrastructure/src/infrastructure/synth/gateway/terraform-application-gateway.ts, indicating a change in how Azure's gateway infrastructure is managed or utilized.
Configuration update
The rush.json file, which is one of the most project's important configuration files, has been updated. This change hints at an adjustment in project standards or workflows.
Website package handling
Manifest files - website/package-lock.json and website/package.json for the website part of the project have also been updated.

Note: The versions of Node.js specified in the engines field have been upgraded from "node": ">=18.0.0 <19.0.0" to "node": ">=20.0.0 <21.0.0". This is an upgrade to a later version of Node.js, implying better performance and access to new Node.js features.

github-actions · 2024-09-11T15:16:01Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2024-09-11T15:16:34Z

❌ Oh no! Integration tests have failed

MarcAstr0 · 2024-09-11T15:19:26Z

/integration sha=1338b5dba5bf9b755b6ab77494eeb43c832f28e9

github-actions · 2024-09-11T15:19:50Z

⌛ Integration tests are running...

Check their status here 👈

MarcAstr0 · 2024-09-11T16:09:50Z

/integration sha=a07e9562ad2be72c4ce58ecc4a2ac57f27f081d2)

github-actions · 2024-09-11T16:10:12Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2024-09-11T16:12:39Z

✅ Integration tests have finished successfully!

github-actions · 2024-09-11T16:12:59Z

❌ Oh no! Integration tests have failed

github-actions · 2024-09-11T17:04:01Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2024-09-11T17:06:47Z

❌ Oh no! Integration tests have failed

MarcAstr0 · 2024-09-11T17:15:18Z

/integration sha=a07e9562ad2be72c4ce58ecc4a2ac57f27f081d2

github-actions · 2024-09-11T17:15:38Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2024-09-11T17:21:15Z

❌ Oh no! Integration tests have failed

MarcAstr0 · 2024-09-11T18:02:49Z

/integration sha=ff18868

github-actions · 2024-09-11T18:03:12Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2024-09-11T18:04:45Z

❌ Oh no! Integration tests have failed

MarcAstr0 · 2024-09-11T18:26:52Z

/integration sha=c6a3c42

github-actions · 2024-09-11T18:27:16Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2024-09-11T18:35:06Z

❌ Oh no! Integration tests have failed

MarcAstr0 · 2024-09-11T18:40:39Z

/integration sha=c6a3c42

github-actions · 2024-09-11T18:41:02Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2024-09-11T18:43:54Z

❌ Oh no! Integration tests have failed

github-actions · 2025-01-30T14:15:54Z

❌ Oh no! Integration tests have failed

github-actions · 2025-01-30T14:40:07Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2025-01-30T14:46:59Z

❌ Oh no! Integration tests have failed

MarcAstr0 · 2025-01-30T14:51:17Z

/integration sha=f61b5bf4cca7cc881a406c88422f65a4f307ddc9

github-actions · 2025-01-30T14:51:39Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2025-01-30T14:57:05Z

❌ Oh no! Integration tests have failed

MarcAstr0 · 2025-01-30T15:26:18Z

/integration sha=f61b5bf4cca7cc881a406c88422f65a4f307ddc9

github-actions · 2025-01-30T15:26:37Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2025-01-30T15:37:57Z

❌ Oh no! Integration tests have failed

MarcAstr0 · 2025-01-30T17:17:32Z

/integration sha=f61b5bf4cca7cc881a406c88422f65a4f307ddc9

github-actions · 2025-01-30T17:17:55Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2025-01-30T17:23:16Z

❌ Oh no! Integration tests have failed

github-actions · 2025-01-30T17:56:52Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2025-01-30T18:46:57Z

✅ Integration tests have finished successfully!

...vider-azure-infrastructure/src/infrastructure/synth/gateway/terraform-application-gateway.ts

common/git-hooks/pre-push

common/config/rush/pnpm-lock.yaml

MarcAstr0 · 2025-02-10T19:53:49Z

/integration sha=475e9473

github-actions · 2025-02-10T19:54:10Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2025-02-10T20:47:15Z

❌ Oh no! Integration tests have failed

github-actions · 2025-02-10T21:04:26Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2025-02-10T21:53:11Z

✅ Integration tests have finished successfully!

davidverdu

LGTM!

Upgrade to Node 20

047bf5a

Change Node version for GitHub actions environment

1338b5d

Change Node version in function app definition

a07e956

Bump @cdktf/provider-azurerm for Node 20 support

ff18868

Update Terraform-related code in Azure provider

c6a3c42

Update Terraform-related code in Azure provider

285d512

MarcAstr0 marked this pull request as ready for review February 10, 2025 15:20

MarcAstr0 added the dependencies Pull requests that update a dependency file label Feb 10, 2025

MarcAstr0 requested a review from davidverdu February 10, 2025 15:20

davidverdu reviewed Feb 10, 2025

View reviewed changes

...vider-azure-infrastructure/src/infrastructure/synth/gateway/terraform-application-gateway.ts Outdated Show resolved Hide resolved

davidverdu reviewed Feb 10, 2025

View reviewed changes

common/git-hooks/pre-push Outdated Show resolved Hide resolved

davidverdu reviewed Feb 10, 2025

View reviewed changes

common/config/rush/pnpm-lock.yaml Outdated Show resolved Hide resolved

Castro, Mario added 2 commits February 10, 2025 15:45

Roll back change to firewall mode

4b28b1f

Bump @types/node version

475e947

davidverdu approved these changes Feb 11, 2025

View reviewed changes

MarcAstr0 merged commit 50cb5ed into boostercloud:main Feb 11, 2025
6 checks passed

MarcAstr0 mentioned this pull request Feb 12, 2025

Update function app and deps to use Node 20 and latest Booster version boostercloud/rocket-webhook#11

Open

Node 20 support #1550

Node 20 support #1550

Conversation

MarcAstr0 commented Sep 11, 2024 • edited Loading

Description

Changes

Checks

MarcAstr0 commented Sep 11, 2024

what-the-diff bot commented Sep 11, 2024

PR Summary

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

MarcAstr0 commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

MarcAstr0 commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

MarcAstr0 commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

MarcAstr0 commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

MarcAstr0 commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

MarcAstr0 commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

MarcAstr0 commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

MarcAstr0 commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

MarcAstr0 commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

MarcAstr0 commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

davidverdu left a comment

Choose a reason for hiding this comment

MarcAstr0 commented Sep 11, 2024 •

edited

Loading