Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Other Act conferences" links sometimes 404 #67

Open
leejo opened this issue Aug 3, 2017 · 2 comments
Open

"Other Act conferences" links sometimes 404 #67

leejo opened this issue Aug 3, 2017 · 2 comments

Comments

@leejo
Copy link

leejo commented Aug 3, 2017

Witness: http://act.perl-workshop.ch/spw2017/user/11869 - the link to the Alpine Perl Workshop 2016 is missing / between the conference name and user/ so results in a 404. Compare: http://act.perl-workshop.ch/spw2017/user/10652 - only the Alpine Perl Workshop 2016 is affected here so must be an issue with the URL as entered for that conference.

Fix needs to happen in https://github.com/book/Act/blob/master/templates/core/user/show#L199

I would look at this but need to build myself an Act VM to work with - do you have anything to automate that or is this a case of "well volunteered"?

@vanHoesel
Copy link

vanHoesel commented Aug 19, 2017

You may probably get away with it by adding the 'trailing-slash' to the full_uri in alpineperl2016/actdocs/conf/act.ini - but you are right, it would also be nice that templates would be less prone to such mistakes.

I would discourage to build an Act VM, a new Act-out-of-the-Box is on it's way!

  • which will give you a checkout of the desired GitHub repository
  • which will allow you to play with all the actdocs and wwwdocs
  • which will allow you to test, and make more changes
  • before pushing a commit to GitHub origin/master for testing and later production

@leejo
Copy link
Author

leejo commented Aug 20, 2017

I was going to build a VM using vagrant, and at BooK's suggestion document the process. I was mainly interested in doing this to see the stack although TBH I'm more interested in the schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants