Skip to content

Commit af2122a

Browse files
author
Bonnie Schulkin
committed
WIP: implementing ESLint suggestions
1 parent 2011fe8 commit af2122a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+3075
-1096
lines changed

.eslintrc

+15-25
Original file line numberDiff line numberDiff line change
@@ -4,40 +4,30 @@
44
"browser": true,
55
"node": true,
66
"es6": true,
7-
"mocha": true
7+
"jest": true
88
},
99
"rules": {
10-
semi: 0,
11-
no-console: 0,
12-
prefer-arrow-callback: 0,
13-
func-names: 0,
14-
no-await-in-loop: 0,
15-
no-unused-expressions: 0,
16-
no-restricted-syntax: [
17-
"error",
18-
"LabeledStatement",
19-
"WithStatement"
20-
],
21-
comma-dangle: ["error", {
22-
arrays: "always-multiline",
23-
objects: "always-multiline",
24-
imports: "always-multiline",
25-
exports: "always-multiline",
26-
functions: "ignore"
10+
"react/jsx-filename-extension": 0,
11+
"jsx-a11y/anchor-is-valid": 0,
12+
"comma-dangle": ["error", {
13+
"arrays": "always-multiline",
14+
"objects": "always-multiline",
15+
"imports": "always-multiline",
16+
"exports": "always-multiline",
17+
"functions": "ignore"
2718
}],
28-
import/no-extraneous-dependencies: [2, { devDependencies: true }],
29-
"valid-jsdoc": ["error", {
19+
"valid-jsdoc": ["error", {
3020
"requireReturn": true,
3121
"requireReturnType": true,
3222
"requireParamDescription": true,
3323
"requireReturnDescription": true
3424
}],
3525
"require-jsdoc": ["error", {
36-
"require": {
37-
"FunctionDeclaration": true,
38-
"MethodDefinition": true,
39-
"ClassDeclaration": true
40-
}
26+
"require": {
27+
"FunctionDeclaration": true,
28+
"MethodDefinition": true,
29+
"ClassDeclaration": true
30+
}
4131
}]
4232
}
4333
}

client/src/app/App.js

+19-18
Original file line numberDiff line numberDiff line change
@@ -24,23 +24,24 @@
2424
* App
2525
*/
2626

27-
import React, { Component } from 'react';
27+
import React from 'react';
2828

29-
import Header from '../nav/header'
30-
import Routes from './Routes'
31-
import ErrorBoundary from './ErrorBoundary'
29+
import Header from '../nav/Header';
30+
import Routes from './Routes';
31+
import ErrorBoundary from './ErrorBoundary';
3232

33-
export default class App extends Component {
34-
render() {
35-
return (
36-
<div>
37-
<ErrorBoundary>
38-
<Header />
39-
</ErrorBoundary>
40-
<ErrorBoundary>
41-
<Routes />
42-
</ErrorBoundary>
43-
</div>
44-
)
45-
}
46-
}
33+
/**
34+
* Application component
35+
* @returns {JSX.Element} - JSX for App component
36+
*/
37+
export default () =>
38+
(
39+
<div>
40+
<ErrorBoundary>
41+
<Header />
42+
</ErrorBoundary>
43+
<ErrorBoundary>
44+
<Routes />
45+
</ErrorBoundary>
46+
</div>
47+
);

0 commit comments

Comments
 (0)