possibility of nil deref in handleReadyMembers

[joel-bluedata]

In the member state detail, LastConnectionVersion (a new thing introduced in recent KD versions) is declared as a pointer-to-int, so if it is not present in the doc then it will be nil in the code.

This field is entirely handled within members.go.

It's first set in handleCreatingMembers.

Later, it's dereferenced in handleReadyMembers -- either directly, or by calling getConnectionVersion (which calls getDefaultConnectionVersion). This dereference is not protected against a possibility of a nil value.

Since creating status comes before ready status, that's not a problem in the normal way of things. However I'm concerned about what will happen if KD is updated to the latest operator version while previously-created kdclusters exist. kdclusters created under old versions of KD will not have this field in their member state yet, and so it looks like we would get a nil deref whenever we first try to do handleReadyMembers on such a kdcluster.