Skip to content

Commit 4696e64

Browse files
otodorovBitnami Containers
authored and
Eduardo Morillo
committed
[bitnami/external-dns] Add support for DaemonSet (bitnami#14080)
* [bitnami/external-dns] Add support for DaemonSet Signed-off-by: Ognyan Todorov <ognyan.tod@gmail.com> * [bitnami/external-dns] Update README file Signed-off-by: Ognyan Todorov <ognyan.tod@gmail.com> * [bitnami/external-dns] Fix README file Signed-off-by: Ognyan Todorov <ognyan.tod@gmail.com> * [bitnami/external-dns]: 1) Rename deployment.yaml to dep-ds.yaml 2) Change variable kind to useDaemonset Signed-off-by: Ognyan Todorov <ognyan.tod@gmail.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * [bitnami/external-dns] Fix README file Signed-off-by: Ognyan Todorov <ognyan.tod@gmail.com> * [bitnami/external-dns] Fix if condition useDaemonset Signed-off-by: Ognyan Todorov <ognyan.tod@gmail.com> Signed-off-by: Ognyan Todorov <ognyan.tod@gmail.com> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: Eduardo Morillo <eduardo.morillo@blueamber.io>
1 parent 589bc36 commit 4696e64

File tree

4 files changed

+14
-3
lines changed

4 files changed

+14
-3
lines changed

bitnami/external-dns/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ sources:
2424
- https://github.com/kubernetes-sigs/external-dns
2525
- https://github.com/bitnami/containers/tree/main/bitnami/external-dns
2626
- https://github.com/kubernetes-sigs/external-dns
27-
version: 6.12.3
27+
version: 6.13.0

bitnami/external-dns/README.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ExternalDNS is a Kubernetes addon that configures public DNS servers with inform
77
[Overview of ExternalDNS](https://github.com/kubernetes-incubator/external-dns)
88

99
Trademarks: This software listing is packaged by Bitnami. The respective trademarks mentioned in the offering are owned by the respective companies, and use of them does not imply any affiliation or endorsement.
10-
10+
1111
## TL;DR
1212

1313
```console
@@ -70,6 +70,7 @@ The command removes all the Kubernetes components associated with the chart and
7070
| `extraDeploy` | Array of extra objects to deploy with the release (evaluated as a template). | `[]` |
7171
| `kubeVersion` | Force target Kubernetes version (using Helm capabilities if not set) | `""` |
7272
| `watchReleaseNamespace` | Watch only namepsace used for the release | `false` |
73+
| `useDaemonset` | Use ExternalDNS in Daemonset mode | `false` |
7374

7475

7576
### external-dns parameters
@@ -484,4 +485,4 @@ Unless required by applicable law or agreed to in writing, software
484485
distributed under the License is distributed on an "AS IS" BASIS,
485486
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
486487
See the License for the specific language governing permissions and
487-
limitations under the License.
488+
limitations under the License.

bitnami/external-dns/templates/deployment.yaml bitnami/external-dns/templates/dep-ds.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
apiVersion: apps/v1
2+
{{- if .Values.useDaemonset }}
3+
kind: DaemonSet
4+
{{- else }}
25
kind: Deployment
6+
{{- end }}
37
metadata:
48
name: {{ template "external-dns.fullname" . }}
59
namespace: {{ .Release.Namespace | quote }}
@@ -11,7 +15,9 @@ metadata:
1115
annotations: {{- include "common.tplvalues.render" ( dict "value" .Values.commonAnnotations "context" $ ) | nindent 4 }}
1216
{{- end }}
1317
spec:
18+
{{ if not .Values.useDaemonset -}}
1419
replicas: {{ coalesce .Values.replicas .Values.replicaCount }}
20+
{{- end }}
1521
{{- if .Values.updateStrategy }}
1622
strategy: {{- toYaml .Values.updateStrategy | nindent 4 }}
1723
{{- end }}

bitnami/external-dns/values.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,10 @@ kubeVersion: ""
4444
## @param watchReleaseNamespace Watch only namepsace used for the release
4545
##
4646
watchReleaseNamespace: false
47+
## @param useDaemonset Use ExternalDNS in Daemonset mode
48+
## If set to false, Deployment will be used.
49+
##
50+
useDaemonset: false
4751

4852
## @section external-dns parameters
4953
##

0 commit comments

Comments
 (0)