Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Transaction trait #1881

Closed
rakita opened this issue Dec 5, 2024 · 3 comments · Fixed by #1959
Closed

Simplify Transaction trait #1881

rakita opened this issue Dec 5, 2024 · 3 comments · Fixed by #1959
Assignees
@rakita
Labels
good first issue Good for newcomers

Comments

@rakita
Copy link
Member

rakita commented Dec 5, 2024

Transaction trait currently require all types of tx to be implemented, this clogs the interface in not a nice way.

Try to introduce simpler trait where all fields are a option.
As first step try to implement this generic on the current trait:
impl<T: TxSimpler> Transaction for TxSimpler {..} this would simplify usage for people

Wait for https://github.com/bluealloy/revm/pull/1865/files to be merged
@rakita rakita added the good first issue Good for newcomers label Dec 5, 2024
@FredCoen
Copy link
Contributor

i'll give it a try!

@rakita
Copy link
Member Author

rakita commented Dec 30, 2024 •
edited
Loading

i'll give it a try!

I am already close to done it

@rakita rakita self-assigned this Dec 30, 2024
@rakita rakita mentioned this issue Dec 30, 2024
Merged
@FredCoen
Copy link
Contributor

ah thanks for telling me got started with it will
have a look at yours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakita rakita

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: simplify Transaction trait bluealloy/revm
2 participants
@rakita @FredCoen