Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#146 Update Basic Auth handler and Options to enable overriding SuppressWWWAuthenticateHeader #147

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

joursler-Sunset
Copy link

Update Basic Auth handler and Options to enable overriding SuppressWWWAuthenticateHeader configuration setting based on the root of the path.

Checklists for Pull requests

About pull request itself:

  • I am submitting a pull request :)
  • [X ] I have already created an issue and referred to it in the commit message.
  • [X ] My submission does one logical thing only (one bugfix, one new feature).
    If want to supply multiple logical changes, I will submit multiple pull requests.
  • [X ] I have read and understood CONTRIBUTING guide

Commits:

  • [X ] My commits are logical, easily readable, with concise comments.

Licensing:

  • [X ] I am the author of submission or have been authorized by submission copyright holder to issue this pull request.

Branching:

  • [X ] My submission is based on master branch.
  • [X ] My submission is compatible with latest master branch updates (no conflicts, I did a rebase if it was necessary).
  • [X ] The name of the branch I want to merge upstream is not 'master' (except for only the most trivial fixes, like typos and such).
  • [X ] My branch name is feature/my-new-not-for-productionfeature (for new features).
  • My branch name is bugfix/i-fixed-your-crap-code (for bugfixes).

Pull request description

Add the necessary code to override the SuppressWWWAuthenticateHeader based on a root path to support libraries that have their own UI and need to send the WWW-Authenticate header while the rest of the application does not.

…ng the SuppressWWWAuthenticateHeader configuration setting based on the root of the path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant