Skip to content

Commit ee6ef0a

Browse files
Warmchayabhinavdangeti
authored andcommitted
Fix missing overload variable in Rocksdb ivf demo (facebookresearch#3326)
Summary: **Bugs:** When following rocksdb_ivf demo to build executable file, its output as: ```bash faiss/demos/rocksdb_ivf/RocksDBInvertedLists.h:52:35: error: 'faiss::InvertedListsIterator* faiss_rocksdb::RocksDBInvertedLists::get_iterator(size_t) const' marked 'override', but does not override 52 | faiss::InvertedListsIterator* get_iterator(size_t list_no) const override; | ^~~~~~~~~~~~ make[2]: *** [CMakeFiles/demo_rocksdb_ivf.dir/build.make:90: CMakeFiles/demo_rocksdb_ivf.dir/RocksDBInvertedLists.cpp.o] Error 1 ``` **Solution:** Add relevant variable `void* inverted_list_contex` corresponding `get_iterator`'s base virtual function. Pull Request resolved: facebookresearch#3326 Reviewed By: mlomeli1, mdouze Differential Revision: D55629580 Pulled By: algoriddle fbshipit-source-id: a12fcacb483e0dd576411ad91a3dd1e0de94abec
1 parent e1f156e commit ee6ef0a

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

demos/rocksdb_ivf/RocksDBInvertedLists.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ void RocksDBInvertedLists::resize(size_t /*list_no*/, size_t /*new_size*/) {
101101
}
102102

103103
InvertedListsIterator* RocksDBInvertedLists::get_iterator(
104-
size_t list_no) const {
104+
size_t list_no,
105+
void* inverted_list_context) const {
105106
return new RocksDBInvertedListsIterator(db_.get(), list_no, code_size);
106107
}
107108

demos/rocksdb_ivf/RocksDBInvertedLists.h

+3-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@ struct RocksDBInvertedLists : faiss::InvertedLists {
4949

5050
void resize(size_t list_no, size_t new_size) override;
5151

52-
faiss::InvertedListsIterator* get_iterator(size_t list_no) const override;
52+
faiss::InvertedListsIterator* get_iterator(
53+
size_t list_no,
54+
void* inverted_list_context) const override;
5355

5456
private:
5557
std::unique_ptr<rocksdb::DB> db_;

0 commit comments

Comments
 (0)