always upload pytest results (facebookresearch#3808)

Summary:
Pull Request resolved: facebookresearch#3808

Previously, we only upload the results when the tests passed. It is useful to also upload results of failing tests for debugging

Reviewed By: ramilbakhshyiev

Differential Revision: D61972433

fbshipit-source-id: 1825e6ebea56279e4d8d8c6480841985c1626674

Author: mengdilin

.github/actions/build_cmake/action.yml

@@ -167,6 +167,7 @@ runs:
         FAISS_DISABLE_CPU_FEATURES=AVX2 LD_DEBUG=libs $CONDA/bin/python -c "import faiss" 2>&1 | grep faiss.so
         LD_DEBUG=libs $CONDA/bin/python -c "import faiss" 2>&1 | grep faiss_avx2.so
     - name: Upload test results
+      if: always()
       uses: actions/upload-artifact@v4
       with:
         name: test-results-arch=${{ runner.arch }}-opt=${{ inputs.opt_level }}-gpu=${{ inputs.gpu }}-raft=${{ inputs.raft }}-rocm=${{ inputs.rocm }}