Skip to content

Commit 98d335b

Browse files
Harry-Chenfacebook-github-bot
authored andcommitted
Some chore fixes (facebookresearch#4010)
Summary: - Fix a typo in comment - Add missing header files to `FAISS_HEADERS` in CMake config There should be some check against the inconsistency between `FAISS_HEADERS` and actual files, e.g. test compiling with installed headers and shared library (otherwise it always succeeds in the source dir). This is not the first time that headers are missing (facebookresearch#3218). Pull Request resolved: facebookresearch#4010 Reviewed By: junjieqi Differential Revision: D65630647 Pulled By: kuarora fbshipit-source-id: 2efcfc4bbd0b2d29efa817e1ff9371942c15d30a
1 parent 3c25a68 commit 98d335b

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

faiss/CMakeLists.txt

+9
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ set(FAISS_HEADERS
125125
IndexIVFPQR.h
126126
IndexIVFSpectralHash.h
127127
IndexLSH.h
128+
IndexNeuralNetCodec.h
128129
IndexLattice.h
129130
IndexNNDescent.h
130131
IndexNSG.h
@@ -168,6 +169,7 @@ set(FAISS_HEADERS
168169
impl/ScalarQuantizer.h
169170
impl/ThreadedIndex-inl.h
170171
impl/ThreadedIndex.h
172+
impl/index_read_utils.h
171173
impl/io.h
172174
impl/io_macros.h
173175
impl/kmeans1d.h
@@ -179,13 +181,17 @@ set(FAISS_HEADERS
179181
impl/code_distance/code_distance.h
180182
impl/code_distance/code_distance-generic.h
181183
impl/code_distance/code_distance-avx2.h
184+
impl/code_distance/code_distance-avx512.h
185+
impl/code_distance/code_distance-sve.h
182186
invlists/BlockInvertedLists.h
183187
invlists/DirectMap.h
184188
invlists/InvertedLists.h
185189
invlists/InvertedListsIOHook.h
190+
invlists/OnDiskInvertedLists.h
186191
utils/AlignedTable.h
187192
utils/bf16.h
188193
utils/Heap.h
194+
utils/NeuralNet.h
189195
utils/WorkerThread.h
190196
utils/distances.h
191197
utils/extra_distances-inl.h
@@ -204,8 +210,10 @@ set(FAISS_HEADERS
204210
utils/sorting.h
205211
utils/simdlib.h
206212
utils/simdlib_avx2.h
213+
utils/simdlib_avx512.h
207214
utils/simdlib_emulated.h
208215
utils/simdlib_neon.h
216+
utils/simdlib_ppc64.h
209217
utils/utils.h
210218
utils/distances_fused/avx512.h
211219
utils/distances_fused/distances_fused.h
@@ -216,6 +224,7 @@ set(FAISS_HEADERS
216224
utils/approx_topk/mode.h
217225
utils/approx_topk_hamming/approx_topk_hamming.h
218226
utils/transpose/transpose-avx2-inl.h
227+
utils/transpose/transpose-avx512-inl.h
219228
utils/hamming_distance/common.h
220229
utils/hamming_distance/generic-inl.h
221230
utils/hamming_distance/hamdis-inl.h

faiss/impl/ResidualQuantizer.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ struct ResidualQuantizer : AdditiveQuantizer {
112112

113113
/** lower-level encode function
114114
*
115-
* @param n number of vectors to hanlde
115+
* @param n number of vectors to handle
116116
* @param residuals vectors to encode, size (n, beam_size, d)
117117
* @param beam_size input beam size
118118
* @param new_beam_size output beam size (should be <= K * beam_size)

tests/test_graph_based.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ def test_build_invalid_knng(self):
335335
"""Make some invalid entries in the input knn graph.
336336
337337
It would cause a warning but IndexNSG should be able
338-
to handel this.
338+
to handle this.
339339
"""
340340
knn_graph = self.make_knn_graph(faiss.METRIC_L2)
341341
knn_graph[:100, 5] = -111

0 commit comments

Comments
 (0)