Skip to content

Commit 6617b13

Browse files
KyleFromNVIDIAfacebook-github-bot
authored andcommitted
Consolidate set_target_properties() calls in faiss/CMakeLists.txt (facebookresearch#3973)
Summary: All of the targets get the same properties and values, so combine them all into one set_target_properties() call for brevity. Pull Request resolved: facebookresearch#3973 Reviewed By: ramilbakhshyiev Differential Revision: D64618572 Pulled By: asadoughi fbshipit-source-id: 6cff95206de936246c015fb81ce324a620ba23fb
1 parent 1a799d0 commit 6617b13

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

faiss/CMakeLists.txt

+1-13
Original file line numberDiff line numberDiff line change
@@ -302,19 +302,7 @@ target_include_directories(faiss_avx512 PUBLIC
302302
target_include_directories(faiss_sve PUBLIC
303303
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>)
304304

305-
set_target_properties(faiss PROPERTIES
306-
POSITION_INDEPENDENT_CODE ON
307-
WINDOWS_EXPORT_ALL_SYMBOLS ON
308-
)
309-
set_target_properties(faiss_avx2 PROPERTIES
310-
POSITION_INDEPENDENT_CODE ON
311-
WINDOWS_EXPORT_ALL_SYMBOLS ON
312-
)
313-
set_target_properties(faiss_avx512 PROPERTIES
314-
POSITION_INDEPENDENT_CODE ON
315-
WINDOWS_EXPORT_ALL_SYMBOLS ON
316-
)
317-
set_target_properties(faiss_sve PROPERTIES
305+
set_target_properties(faiss faiss_avx2 faiss_avx512 faiss_sve PROPERTIES
318306
POSITION_INDEPENDENT_CODE ON
319307
WINDOWS_EXPORT_ALL_SYMBOLS ON
320308
)

0 commit comments

Comments
 (0)