HNSW search use efSearch from params if provided (facebookresearch#3233)

xinhuitian · facebook-github-bot · commit 31a29d03784b · 2024-02-02T02:31:57.000-08:00
Summary: I found that HNSW search method uses its own efSearch to create candidates, which should be got from params if provided I think? Pull Request resolved: facebookresearch#3233 Reviewed By: algoriddle Differential Revision: D53342879 Pulled By: mdouze fbshipit-source-id: 4f47f19d3673d1bb8d7e8e82745f9e5c1b9afb42
diff --git a/faiss/impl/HNSW.cpp b/faiss/impl/HNSW.cpp
@@ -829,7 +829,7 @@ HNSWStats HNSW::search(
             greedy_update_nearest(*this, qdis, level, nearest, d_nearest);
         }
 
-        int ef = std::max(efSearch, k);
+        int ef = std::max(params ? params->efSearch : efSearch, k);
         if (search_bounded_queue) { // this is the most common branch
             MinimaxHeap candidates(ef);
 

Original file line number	Diff line number	Diff line change
`@@ -829,7 +829,7 @@ HNSWStats HNSW::search(`
`829`	`829`	`greedy_update_nearest(*this, qdis, level, nearest, d_nearest);`
`830`	`830`	`}`
`831`	`831`
`832`		`- int ef = std::max(efSearch, k);`
	`832`	`+ int ef = std::max(params ? params->efSearch : efSearch, k);`
`833`	`833`	`if (search_bounded_queue) { // this is the most common branch`
`834`	`834`	`MinimaxHeap candidates(ef);`
`835`	`835`