Skip to content

Commit 0c07a11

Browse files
algoriddlefacebook-github-bot
authored andcommitted
fix raft contbuild and switch to libraft 23.12 (facebookresearch#3116)
Summary: Pull Request resolved: facebookresearch#3116 Test Plan: https://app.circleci.com/pipelines/github/facebookresearch/faiss/4839/workflows/cfd84a94-ca60-4128-96e6-db0f5afc69c4 Reviewed By: mdouze Differential Revision: D50897934 Pulled By: algoriddle fbshipit-source-id: 1422be39d640a2aec3ab6b4c68d3ef54900b5ba2
1 parent 9bb6b4b commit 0c07a11

File tree

4 files changed

+15
-12
lines changed

4 files changed

+15
-12
lines changed

.circleci/config.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ executors:
99
environment:
1010
CONDA_ARCH: Linux-x86_64
1111
machine:
12-
image: linux-cuda-11:2023.02.1
12+
image: linux-cuda-11:default
1313
resource_class: gpu.nvidia.medium
1414
linux-arm64-cpu:
1515
environment:
@@ -91,7 +91,7 @@ jobs:
9191
- run:
9292
name: Install conda build tools
9393
command: |
94-
conda config --set solver libmamba
94+
# conda config --set solver libmamba
9595
# conda config --set verbosity 3
9696
conda update -y -q conda
9797
conda install -y -q conda-build
@@ -171,7 +171,7 @@ jobs:
171171
sudo update-alternatives --set cuda /usr/local/cuda-<<parameters.cuda>>
172172
cd conda
173173
conda build faiss-gpu-raft --variants '{ "cudatoolkit": "<<parameters.cuda>>", "c_compiler_version": "<<parameters.compiler_version>>", "cxx_compiler_version": "<<parameters.compiler_version>>" }' \
174-
-c pytorch -c nvidia -c rapidsai -c conda-forge
174+
-c pytorch -c nvidia -c rapidsai-nightly -c conda-forge
175175
- when:
176176
condition:
177177
and:
@@ -186,7 +186,7 @@ jobs:
186186
sudo update-alternatives --set cuda /usr/local/cuda-<<parameters.cuda>>
187187
cd conda
188188
conda build faiss-gpu-raft --variants '{ "cudatoolkit": "<<parameters.cuda>>", "c_compiler_version": "<<parameters.compiler_version>>", "cxx_compiler_version": "<<parameters.compiler_version>>" }' \
189-
--user pytorch --label <<parameters.label>> -c pytorch -c nvidia -c rapidsai -c conda-forge
189+
--user pytorch --label <<parameters.label>> -c pytorch -c nvidia -c rapidsai-nightly -c conda-forge
190190
191191
build_cmake:
192192
parameters:
@@ -236,7 +236,7 @@ jobs:
236236
- run:
237237
name: Install libraft
238238
command: |
239-
conda install -y -q libraft cudatoolkit=11.4 -c rapidsai-nightly -c nvidia -c pkgs/main -c conda-forge
239+
conda install -y -q libraft cuda-version=11.4 -c rapidsai-nightly -c nvidia -c pkgs/main -c conda-forge
240240
- run:
241241
name: Build all targets
242242
no_output_timeout: 30m
@@ -283,7 +283,7 @@ jobs:
283283
- run:
284284
name: Python tests (CPU + GPU)
285285
command: |
286-
conda install -y -q pytorch pytorch-cuda -c pytorch -c nvidia
286+
conda install -y -q pytorch pytorch-cuda=11 -c pytorch -c nvidia
287287
pytest --junitxml=test-results/pytest/results.xml tests/test_*.py
288288
pytest --junitxml=test-results/pytest/results-torch.xml tests/torch_*.py
289289
cp tests/common_faiss_tests.py faiss/gpu/test

cmake/thirdparty/fetch_rapids.cmake

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# or implied. See the License for the specific language governing permissions and limitations under
1616
# the License.
1717
# =============================================================================
18-
set(RAPIDS_VERSION "23.08")
18+
set(RAPIDS_VERSION "23.12")
1919

2020
if(NOT EXISTS ${CMAKE_CURRENT_BINARY_DIR}/FAISS_RAPIDS.cmake)
2121
file(DOWNLOAD https://raw.githubusercontent.com/rapidsai/rapids-cmake/branch-${RAPIDS_VERSION}/RAPIDS.cmake

conda/faiss-gpu-raft/meta.yaml

+6-4
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ outputs:
4747
host:
4848
- mkl =2023 # [x86_64]
4949
- openblas # [not x86_64]
50-
- cudatoolkit {{ cudatoolkit }}
51-
- libraft =23.08
50+
- cuda-version {{ cudatoolkit }}
51+
- libraft =23.12
5252
run:
5353
- mkl =2023 # [x86_64]
5454
- openblas # [not x86_64]
55-
- {{ pin_compatible('cudatoolkit', max_pin='x.x') }}
56-
- libraft =23.08
55+
- {{ pin_compatible('cuda-version', max_pin='x') }}
56+
- libraft =23.12
5757
test:
5858
requires:
5959
- conda-build
@@ -90,6 +90,8 @@ outputs:
9090
- numpy
9191
- scipy
9292
- pytorch
93+
- pytorch-cuda =11.8
94+
- cuda-version =11.8
9395
commands:
9496
- python -X faulthandler -m unittest discover -v -s tests/ -p "test_*"
9597
- python -X faulthandler -m unittest discover -v -s tests/ -p "torch_*"

conda/faiss-gpu/meta.yaml

+2-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ outputs:
5151
run:
5252
- mkl =2023 # [x86_64]
5353
- openblas # [not x86_64]
54-
- {{ pin_compatible('cudatoolkit', max_pin='x.x') }}
54+
- {{ pin_compatible('cudatoolkit', max_pin='x') }}
5555
test:
5656
requires:
5757
- conda-build
@@ -88,6 +88,7 @@ outputs:
8888
- numpy
8989
- scipy
9090
- pytorch
91+
- pytorch-cuda =11.8
9192
commands:
9293
- python -X faulthandler -m unittest discover -v -s tests/ -p "test_*"
9394
- python -X faulthandler -m unittest discover -v -s tests/ -p "torch_*"

0 commit comments

Comments
 (0)