From 4706fa680fdee3719e4f523f19a74b6b67d491bc Mon Sep 17 00:00:00 2001 From: Bobby Earl Date: Tue, 6 Jun 2017 09:50:08 -0400 Subject: [PATCH 1/3] Fixed deps + test --- lib/sky-pages-module-generator.js | 2 +- test/sky-pages-module-generator.spec.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/sky-pages-module-generator.js b/lib/sky-pages-module-generator.js index a34f5979..a5872b6a 100644 --- a/lib/sky-pages-module-generator.js +++ b/lib/sky-pages-module-generator.js @@ -60,7 +60,7 @@ function getSource(skyAppConfig) { runtimeProviders.push(`{ provide: SkyAuthHttp, useClass: SkyAuthHttp, - deps: [XHRBackend, RequestOptions, SkyAppWindowRef, SkyAuthTokenProvider] + deps: [XHRBackend, RequestOptions, SkyAuthTokenProvider, SkyAppConfig] }`); } diff --git a/test/sky-pages-module-generator.spec.js b/test/sky-pages-module-generator.spec.js index 67fef901..c20281d6 100644 --- a/test/sky-pages-module-generator.spec.js +++ b/test/sky-pages-module-generator.spec.js @@ -78,7 +78,7 @@ describe('SKY UX Builder module generator', () => { const expectedProvider = `{ provide: SkyAuthHttp, useClass: SkyAuthHttp, - deps: [XHRBackend, RequestOptions, SkyAppWindowRef, SkyAuthTokenProvider] + deps: [XHRBackend, RequestOptions, SkyAuthTokenProvider, SkyAppConfig] }`; let source = generator.getSource({ From e7fc723716d831c4fa8b9a74d1c8473bfc7260b0 Mon Sep 17 00:00:00 2001 From: Bobby Earl Date: Tue, 6 Jun 2017 10:25:53 -0400 Subject: [PATCH 2/3] Added new test + note --- runtime/auth-http.spec.ts | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/runtime/auth-http.spec.ts b/runtime/auth-http.spec.ts index 4b446e96..b4511d85 100644 --- a/runtime/auth-http.spec.ts +++ b/runtime/auth-http.spec.ts @@ -128,4 +128,14 @@ describe('SkyAuthHttp', () => { }); }); + /** + * PLEASE NOTE + * If this tests fails, it means you've changed the required parameters to the constructor. + * To successfully maintain backwards compatibility, make any new parameters optional. + */ + it('should maintain backwards compatibility if new parameters added to the constructor', () => { + setupInjector(''); + expect(skyAuthHttp).toBeDefined(); + }); + }); From cef93ae3413ebc8b7947baddc8d80c2fe030ebba Mon Sep 17 00:00:00 2001 From: Bobby Earl Date: Tue, 6 Jun 2017 10:41:29 -0400 Subject: [PATCH 3/3] Updated test comment and package.json. Added entry for CHANGELOG.md --- CHANGELOG.md | 4 ++++ package.json | 2 +- runtime/auth-http.spec.ts | 4 +++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3aeea313..2b1ba920 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # 1.0.0-beta.29 (2017-06-05) +- Bugfix for `SkyAuthHttp`. [#171](https://github.com/blackbaud/skyux-builder/pull/171) + +# 1.0.0-beta.29 (2017-06-05) + - Implemented style loader to resolve FOUC (flash of unstyled content). [#166](https://github.com/blackbaud/skyux-builder/pull/166) - Initial creation of `skyRouterLink` directive. [#159](https://github.com/blackbaud/skyux-builder/pull/159) - Updated testing suite to include internal files in `src/app` directory. diff --git a/package.json b/package.json index 880c2e9a..d93d437e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@blackbaud/skyux-builder", - "version": "1.0.0-beta.29", + "version": "1.0.0-beta.30", "description": "Builds the output of a SKY UX application.", "main": "index.js", "scripts": { diff --git a/runtime/auth-http.spec.ts b/runtime/auth-http.spec.ts index b4511d85..41f454ab 100644 --- a/runtime/auth-http.spec.ts +++ b/runtime/auth-http.spec.ts @@ -131,7 +131,9 @@ describe('SkyAuthHttp', () => { /** * PLEASE NOTE * If this tests fails, it means you've changed the required parameters to the constructor. - * To successfully maintain backwards compatibility, make any new parameters optional. + * To successfully maintain backwards compatibility: + * - make any new parameters optional + * - add any new parameters to the end of the constructor */ it('should maintain backwards compatibility if new parameters added to the constructor', () => { setupInjector('');