Added codeCoverageThreshold property and tests (#355)

Author: Bobby Earl

config/karma/shared.karma.conf.js

@@ -1,6 +1,35 @@
 /*jslint node: true */
 'use strict';
 
+/**
+ * Adds the necessary configuration for code coverage thresholds.
+ * @param {*} config
+ */
+function getCoverageThreshold(skyPagesConfig) {
+
+  function getProperty(threshold) {
+    return {
+      global: {
+        statements: threshold,
+        branches: threshold,
+        functions: threshold,
+        lines: threshold
+      }
+    };
+  }
+
+  switch (skyPagesConfig.skyux.codeCoverageThreshold) {
+    case 'none':
+      return getProperty(0);
+
+    case 'standard':
+      return getProperty(80);
+
+    case 'strict':
+      return getProperty(100);
+  }
+}
+
 /**
  * Common Karma configuration shared between local / CI testing.
  * @name getConfig
@@ -43,9 +72,11 @@ function getConfig(config) {
     webpack: testWebpackConfig.getWebpackConfig(skyPagesConfig, argv),
     coverageReporter: {
       dir: path.join(process.cwd(), 'coverage'),
+      check: getCoverageThreshold(skyPagesConfig),
       reporters: [
         { type: 'json' },
-        { type: 'html' }
+        { type: 'html' },
+        { type: 'text-summary' }
       ],
       _onWriteReport: function (collector) {
         return remapIstanbul.remap(collector.getFinalCoverage());

runtime/config.ts

@@ -57,9 +57,10 @@ export interface SkyuxConfig {
   app?: SkyuxConfigApp;
   appSettings?: any;
   auth?: boolean;
-  cssPath?: string;
+  codeCoverageThreshold?: 'none' | 'standard' | 'strict';
   command?: string;
   compileMode?: string;
+  cssPath?: string;
   help?: any;
   host?: SkyuxConfigHost;
   importPath?: string;

test/config-karma-shared.spec.js

@@ -46,6 +46,10 @@ describe('config karma shared', () => {
       getSkyPagesConfig: (command) => {
         expect(command).toBe(customCommand);
         done();
+
+        return {
+          skyux: {}
+        };
       }
     });
 
@@ -54,4 +58,62 @@ describe('config karma shared', () => {
     });
   });
 
+  function checkCodeCoverage(configValue, threshold) {
+
+    mock('../config/sky-pages/sky-pages.config.js', {
+      getSkyPagesConfig: () => ({
+        skyux: {
+          codeCoverageThreshold: configValue
+        }
+      })
+    });
+
+    mock(testConfigFilename, {
+      getWebpackConfig: () => {}
+    });
+
+    mock.reRequire('../config/karma/shared.karma.conf')({
+      set: (config) => {
+        expect(config.coverageReporter.check).toEqual({
+          global: {
+            statements: threshold,
+            branches: threshold,
+            functions: threshold,
+            lines: threshold
+          }
+        });
+      }
+    });
+  }
+
+  it('should not add the check property when codeCoverageThreshold is not defined', () => {
+    mock('../config/sky-pages/sky-pages.config.js', {
+      getSkyPagesConfig: () => ({
+        skyux: {}
+      })
+    });
+
+    mock(testConfigFilename, {
+      getWebpackConfig: () => {}
+    });
+
+    mock.reRequire('../config/karma/shared.karma.conf')({
+      set: (config) => {
+        expect(config.coverageReporter.check).toBeUndefined();
+      }
+    });
+  });
+
+  it('should handle codeCoverageThreshold set to "none"', () => {
+    checkCodeCoverage('none', 0);
+  });
+
+  it('should handle codeCoverageThreshold set to "standard"', () => {
+    checkCodeCoverage('standard', 80);
+  });
+
+  it('should handle codeCoverageThreshold set to "strict"', () => {
+    checkCodeCoverage('strict', 100);
+  });
+
 });