Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the implementation on new XLMOD STRUCTURE: #77

Open
dikshant182004 opened this issue Mar 8, 2025 · 4 comments
Open

Update the implementation on new XLMOD STRUCTURE: #77

dikshant182004 opened this issue Mar 8, 2025 · 4 comments

Comments

@dikshant182004
Copy link

it would be great if we can add a temporary cache directory support for all modules while testing .

@bittremieux
Copy link
Member

Can you please provide additional information? Currently it's unclear what is leading to the error. Please include details on how you got this error and include a full stack trace.

@dikshant182004
Copy link
Author

hi @bittremieux ,these are some additional details regarding the error ,there are various areas in the code where we are using the cache directory is leading to errors because they are not able to import CV's from it like there was a assertion error here and similarly othere issues are occuring due to cache directory ,as we have disabled it here due to some reasons ,so i feel adding a temorary cache directory support would be nice for all the modules while testing so we can ensure that these funtions are working fine . there are some of the trace for it .

Image
If i am going wrong somewhere do tell me .

@bittremieux
Copy link
Member

These three errors all refer to terms from the XLMOD controlled vocabulary. Did you get errors for terms from any of the other CVs (e.g. UNIMOD or PSI-MOD)? This seems rather related to XLMOD specifically rather than the caching. Additionally, please try to manually clear the cache directory to make sure that the issue is not due to a corrupted download.

@dikshant182004
Copy link
Author

hi @bittremieux ,u were right first three errors are due to the XLMOD ,due to its updation .I was not able to find XLMOD:02001 in the provided link as it is being updated .second the assertion errors (fourth one ) we were facing because the XLMOD structure is being changed ,so our parsng logic is returning zero for XLMOD which eventually cause the error >
1543 UNIMOD
1623 MOD
645 RESID
0 XLMOD
i have made small change in the parsing logic so we are left with only three errors .one more thing is that we were facing a keyerror :'value' that was due to pyteomics usi implementation .I have raise the error in pyteomics .so it will be get corrected .In my local machine i have only encountered with three errors which are due to XLMOD implementation .so i will change the title of this error.

@dikshant182004 dikshant182004 changed the title Assertion Error , there is problem in importing CVs in test funtions in proforma_test.py Update the implementation on new XLMOD STRUCTURE: Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants