Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set exit code 1 when a command errors out #208

Closed
joeirimpan opened this issue Jul 20, 2022 · 2 comments · Fixed by #219
Closed

Set exit code 1 when a command errors out #208

joeirimpan opened this issue Jul 20, 2022 · 2 comments · Fixed by #219

Comments

@joeirimpan
Copy link
Contributor

joeirimpan commented Jul 20, 2022 •
edited
Loading

@birdayz Thanks for this easy-to-use kafka cli.

Is there a specific reason we are not setting exit 1 when a command like kaf topic create test-topic fails?
@joeirimpan
Copy link
Contributor Author

joeirimpan commented Aug 22, 2022 •
edited
Loading

@birdayz i am sure you must be busy, but bumping this up to hear your thoughts. Thanks again!

@birdayz
Copy link
Owner

birdayz commented Aug 26, 2022

sorry for the late response. this is a bug.

@joeirimpan joeirimpan mentioned this issue Aug 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Set exit flag when create/delete command fails joeirimpan/kaf
2 participants
@joeirimpan @birdayz