📝 formatting compat issues

[nstepien]

Environment information

Playground

What happened?

Hey, it's me again with more formatting discrepancies I found in our codebases.

• https://biomejs.dev/playground/?lineWidth=100&indentStyle=space&quoteStyle=single&trailingComma=none&lintRules=all&enabledLinting=false&code=ZQB4AHAAbwByAHQAIABjAG8AbgBzAHQAIABGAGkAbAB0AGUAcgBCAHUAdAB0AG8AbgAgAD0AIABmAG8AcgB3AGEAcgBkAFIAZQBmADwASABUAE0ATABCAHUAdAB0AG8AbgBFAGwAZQBtAGUAbgB0ACwAIABGAGkAbAB0AGUAcgBCAHUAdAB0AG8AbgBQAHIAbwBwAHMAPgAoAAoAIAAgAGYAdQBuAGMAdABpAG8AbgAgAEYAaQBsAHQAZQByAEIAdQB0AHQAbwBuACgAcAByAG8AcABzACwAIAByAGUAZgApACAAewAKACAAIAAgACAAcgBlAHQAdQByAG4AIAA8AGIAdQB0AHQAbwBuACAAcgBlAGYAPQB7AHIAZQBmAH0AIAAvAD4AOwAKACAAIAB9AAoAKQA7AAoA
• https://biomejs.dev/playground/?lineWidth=100&indentStyle=space&quoteStyle=single&trailingComma=none&lintRules=all&enabledLinting=false&code=ZQB4AHAAbwByAHQAIABkAGUAZgBhAHUAbAB0ACAAZgBvAHIAdwBhAHIAZABSAGUAZgAoAFMAZQBsAGUAYwB0ACkAIABhAHMAIAA8AAoAIAAgAEkARAAgAGUAeAB0AGUAbgBkAHMAIABzAHQAcgBpAG4AZwAgAHwAIABuAHUAbQBiAGUAcgAsAAoAIAAgAEcAUgBPAFUAUABJAEQAIABlAHgAdABlAG4AZABzACAAcwB0AHIAaQBuAGcAIAB8ACAAbgB1AG0AYgBlAHIAIAA9ACAAcwB0AHIAaQBuAGcAIAB8ACAAbgB1AG0AYgBlAHIACgA%2BACgACgAgACAAcAByAG8AcABzADoAIABTAGUAbABlAGMAdABQAHIAbwBwAHMAPABJAEQALAAgAEcAUgBPAFUAUABJAEQAPgAgACYAIABSAGUAYQBjAHQALgBSAGUAZgBBAHQAdAByAGkAYgB1AHQAZQBzADwASABUAE0ATABJAG4AcAB1AHQARQBsAGUAbQBlAG4AdAA%2BAAoAKQAgAD0APgAgAEoAUwBYAC4ARQBsAGUAbQBlAG4AdAA7AA%3D%3D
• https://biomejs.dev/playground/?indentStyle=space&quoteStyle=single&trailingComma=none&enabledLinting=false&code=ZgB1AG4AYwB0AGkAbwBuACAAdABlAHMAdAAoACkAIAB7AAoAIAAgAHIAZQB0AHUAcgBuACAAZgBuACgAKAApACAAPQA%2BACAAewAKACAAIAAgACAAcgBlAHQAdQByAG4AIABgACQAewBhAGEAYQBhAGEAYQBhAGEAYQBhAGEAYQB9ACAAJAB7AGIAYgBiAGIAYgBiAGIAYgBiAGIAYgBiAGIAYgBiACAAPwA%2FACAAJwAnAH0AIAAkAHsACgAgACAAIAAgACAAIABjAGMAYwBjAGMAYwBjAGMAYwBjAGMAYwBjAGMAYwBjAGMAIAA%2FAD8AIAAnACcACgAgACAAIAAgAH0AYAA7AAoAIAAgAH0AKQA7AAoAfQAKAA%3D%3D
  • This one is interesting, if you remove fn then it formats identically

Expected result

Prettier compatibility.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[faultyserver]

The first bug here happens because the formatter uses a BestFitting set when laying out arguments to a call expression, and it somehow manages to pick the middle variant rather than falling back to the fully-broken-out layout. I've been trying to address that to solve a number of other prettier diffs (like prettier/js/arrows/curried and the like), and i've got this diff here that gets sort of close: https://github.com/biomejs/biome/compare/main..challenge/arrow-curry.

I think it's on the right track, but not at all close yet, I might spend more time looking at it, but also happy if anyone else has an intuition and can get it fixed faster lol

[nstepien]

Thank you all!