Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 use ignore crate for walking the file system #847

Closed
ematipico opened this issue Nov 23, 2023 · 2 comments · Fixed by #1134
Closed

📎 use ignore crate for walking the file system #847

ematipico opened this issue Nov 23, 2023 · 2 comments · Fixed by #1134
Assignees
Labels
A-CLI Area: CLI A-Project Area: project

Comments

@ematipico
Copy link
Member

Description

At the moment we use some in-house code for walking the file system and for matching globs to ignore the files.

While this works, we have some issues:

  • we can't respect nested gitignore files during the traversal
  • our glob matcher is a copy of the glob crate and it doesn't work very well with the gitignore paths
  • we can't use globs in our cli

https://docs.rs/ignore/latest/ignore/index.html

We use this crate to enhance the feature.

@ematipico ematipico added A-CLI Area: CLI A-Project Area: project labels Nov 23, 2023
@ematipico ematipico changed the title 📎 <TITLE> 📎 use ignore crate for walking the file system Nov 23, 2023
@malobre
Copy link
Contributor

malobre commented Nov 29, 2023

@ematipico ematipico self-assigned this Dec 9, 2023
@ematipico
Copy link
Member Author

I'm currently working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Project Area: project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants