Improved getOwners and developed relative tests. All tests pass #38

Author: gicaz

api/services/OperatorService.js

@@ -6,7 +6,7 @@
 
 /* jshint esnext: true */
 /* jshint node: true */
-/* globals _, sails , GroupService */
+/* globals _, sails , GroupService, DataType */
 
 const BluebirdPromise = require('bluebird');
 
@@ -17,8 +17,16 @@ const coroutines = {
         if (!datum || !datum.type) {
             return [];
         }
-        let idProject = _.isObject(datum.type.project) ? datum.type.project.id : datum.type.project;
-        // _.isObject(datum.type.project);
+
+        let idProject;
+        if (!_.isObject(datum.type)) {
+            let dataType = yield DataType.findOne(datum.type);
+            idProject = dataType.project;
+        }
+        else {
+            idProject = _.isObject(datum.type.project) ? datum.type.project.id : datum.type.project;
+        }
+
         let groups = yield GroupService.getGroupsByProject(idProject);
 
         let operators = _.uniq(_.flatten(_.map(groups,'members')));

test/unit/services/OperatorService.test.js

@@ -0,0 +1,55 @@
+/* jshint node:true */
+/* jshint mocha: true */
+/* globals _, sails, fixtures, OperatorService, DataType*/
+"use strict";
+var chai = require("chai");
+var expect = chai.expect, sinon = require('sinon');
+
+describe('OperatorService', function() {
+
+    describe('#getOwners', function() {
+
+        it("should return an empty array", function(done) {
+            // var idProject = fixtures.project[0].id;
+
+            OperatorService.getOwners().then(function (err,res) {
+
+                expect(res).to.be.empty;
+                done();
+                return;
+            });
+        });
+
+
+        it("should return an array containg all elegible owners", function(done) {
+            let spy = sinon.spy(DataType, "findOne");
+            var datum = _.cloneDeep(fixtures.data[0]);
+            datum.type = _.cloneDeep(fixtures.datatype[2]);
+            var expectedOperators = _.cloneDeep(fixtures.operator);
+
+            OperatorService.getOwners(datum).then(function (res) {
+                sinon.assert.notCalled(spy);
+                expect(res.length).to.eql(expectedOperators.length);
+
+                DataType.findOne.restore();
+                done();
+                return;
+            });
+        });
+
+        it("should return an array containg all elegible owners retrieving dataType ", function(done) {
+            let spy = sinon.spy(DataType, "findOne");
+            var datum = _.cloneDeep(fixtures.data[0]);
+            var expectedOperators = _.cloneDeep(fixtures.operator);
+            OperatorService.getOwners(datum).then(function (res) {
+                sinon.assert.called(spy);
+                expect(res.length).to.eql(expectedOperators.length);
+
+                DataType.findOne.restore();
+                done();
+                return;
+            });
+        });
+    });
+
+});