Fix linter warnings

Author: bikeshedder

tusker-query/src/types.rs

@@ -38,21 +38,21 @@ pub struct PgUuid;
 /// JSON, JSONB
 pub struct PgJson;
 
-impl<'a> FromSqlTyped<'a, PgBool> for bool {}
-impl<'a> FromSqlTyped<'a, PgI8> for i8 {}
-impl<'a> FromSqlTyped<'a, PgI16> for i16 {}
-impl<'a> FromSqlTyped<'a, PgI32> for i32 {}
-impl<'a> FromSqlTyped<'a, PgI64> for i64 {}
-impl<'a> FromSqlTyped<'a, PgF32> for f32 {}
-impl<'a> FromSqlTyped<'a, PgF64> for f64 {}
+impl FromSqlTyped<'_, PgBool> for bool {}
+impl FromSqlTyped<'_, PgI8> for i8 {}
+impl FromSqlTyped<'_, PgI16> for i16 {}
+impl FromSqlTyped<'_, PgI32> for i32 {}
+impl FromSqlTyped<'_, PgI64> for i64 {}
+impl FromSqlTyped<'_, PgF32> for f32 {}
+impl FromSqlTyped<'_, PgF64> for f64 {}
 impl<'a> FromSqlTyped<'a, PgString> for &'a str {}
-impl<'a> FromSqlTyped<'a, PgString> for String {}
+impl FromSqlTyped<'_, PgString> for String {}
 impl<'a> FromSqlTyped<'a, PgBytea> for &'a [u8] {}
-impl<'a> FromSqlTyped<'a, PgBytea> for Vec<u8> {}
-impl<'a> FromSqlTyped<'a, PgHstore> for HashMap<String, Option<String>> {}
-impl<'a> FromSqlTyped<'a, PgTimestamp> for SystemTime {}
-impl<'a> FromSqlTyped<'a, PgTimestampTz> for SystemTime {}
-impl<'a> FromSqlTyped<'a, PgInet> for IpAddr {}
+impl FromSqlTyped<'_, PgBytea> for Vec<u8> {}
+impl FromSqlTyped<'_, PgHstore> for HashMap<String, Option<String>> {}
+impl FromSqlTyped<'_, PgTimestamp> for SystemTime {}
+impl FromSqlTyped<'_, PgTimestampTz> for SystemTime {}
+impl FromSqlTyped<'_, PgInet> for IpAddr {}
 
 #[cfg(feature = "with-time-0_3")]
 impl<'a> FromSqlTyped<'a, PgTimestamp> for time_03::PrimitiveDateTime {}

tusker-schema/src/models/column.rs

@@ -82,7 +82,7 @@ pub enum Identity {
     Default,
 }
 
-impl<'a> DiffSql for Diff<'a, Column> {
+impl DiffSql for Diff<'_, Column> {
     fn sql(&self) -> Vec<(ChangeType, String)> {
         let mut v = Vec::new();
         for a in &self.a_only {

tusker-schema/src/models/constraint.rs

@@ -71,7 +71,7 @@ impl<'a> FromSql<'a> for ConstraintType {
     }
 }
 
-impl<'a> DiffSql for Diff<'a, Constraint> {
+impl DiffSql for Diff<'_, Constraint> {
     fn sql(&self) -> Vec<(ChangeType, String)> {
         let mut v = Vec::new();
         for a in &self.a_only {

tusker-schema/src/models/schema.rs

@@ -21,19 +21,19 @@ impl Schema {
             ..Default::default()
         }
     }
-    pub fn diff_tables<'a>(&'a self, other: &'a Self) -> Diff<'_, Table> {
+    pub fn diff_tables<'a>(&'a self, other: &'a Self) -> Diff<'a, Table> {
         diff(self.tables.values(), other.tables.values(), |table| {
             &table.name
         })
     }
-    pub fn diff_constraints<'a>(&'a self, other: &'a Self) -> Diff<'_, Constraint> {
+    pub fn diff_constraints<'a>(&'a self, other: &'a Self) -> Diff<'a, Constraint> {
         diff(self.constraints.values(), other.constraints.values(), |c| {
             (&c.table, &c.name)
         })
     }
 }
 
-impl<'a> DiffSql for Diff<'a, Schema> {
+impl DiffSql for Diff<'_, Schema> {
     fn sql(&self) -> Vec<(ChangeType, String)> {
         let mut v = Vec::new();
         if !self.a_only.is_empty() {

tusker-schema/src/models/table.rs

@@ -64,7 +64,7 @@ impl Table {
     }
 }
 
-impl<'a> DiffSql for Diff<'a, Table> {
+impl DiffSql for Diff<'_, Table> {
     fn sql(&self) -> Vec<(ChangeType, String)> {
         let mut v = Vec::new();
         for a in &self.a_only {

tusker-schema/src/sql.rs

@@ -1,3 +1,5 @@
+use std::fmt;
+
 #[derive(Debug, Default)]
 pub struct StatementBuilder {
     parts: Vec<String>,
@@ -15,9 +17,9 @@ impl StatementBuilder {
     }
 }
 
-impl ToString for StatementBuilder {
-    fn to_string(&self) -> String {
-        self.parts.join(" ")
+impl fmt::Display for StatementBuilder {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        write!(f, "{}", self.parts.join(" "))
     }
 }