Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update license link in README.md #5614

Closed
wants to merge 1 commit into from

Conversation

Piturnah
Copy link
Contributor

@Piturnah Piturnah commented Aug 8, 2022

Objective

The LICENSE file in the root directory was removed in #4966. This breaks the license shield link in the README.

Solution

I changed the link to instead point at the license section of the readme on the main repo page. I think this is better than a 404, but I am unsure as to if it's the best solution. As such feedback is appreciated.

@NiklasEi
Copy link
Member

NiklasEi commented Aug 8, 2022

That is the best link I could come up with, too 👍

@NiklasEi NiklasEi added the A-Meta About the project itself label Aug 8, 2022
@cart
Copy link
Member

cart commented Aug 8, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 8, 2022
# Objective

The `LICENSE` file in the root directory was removed in #4966. This breaks the license shield link in the README.

## Solution

I changed the link to instead point at the license section of the readme on the main repo page. I think this is better than a 404, but I am unsure as to if it's the best solution. As such feedback is appreciated.
@bors bors bot changed the title Update license link in README.md [Merged by Bors] - Update license link in README.md Aug 8, 2022
@bors bors bot closed this Aug 8, 2022
@Piturnah Piturnah deleted the update-license-link branch August 14, 2022 09:06
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
# Objective

The `LICENSE` file in the root directory was removed in bevyengine#4966. This breaks the license shield link in the README.

## Solution

I changed the link to instead point at the license section of the readme on the main repo page. I think this is better than a 404, but I am unsure as to if it's the best solution. As such feedback is appreciated.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

The `LICENSE` file in the root directory was removed in bevyengine#4966. This breaks the license shield link in the README.

## Solution

I changed the link to instead point at the license section of the readme on the main repo page. I think this is better than a 404, but I am unsure as to if it's the best solution. As such feedback is appreciated.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

The `LICENSE` file in the root directory was removed in bevyengine#4966. This breaks the license shield link in the README.

## Solution

I changed the link to instead point at the license section of the readme on the main repo page. I think this is better than a 404, but I am unsure as to if it's the best solution. As such feedback is appreciated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Meta About the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants