-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mio 0.7 support #23
Comments
A quick glance through @raffber's changes for mio-serial and tokio-serial looks OK. I haven't had any use of tokio-serial for a good while now but I can pull his changes in and push new versions to crates.io |
Actually, looking closer none of the AsyncRead or AsyncWrite methods are implemented.. |
Yes, I have not done any significant work on this, since I quickly realized that I was stuck with tokio 0.2 / mio 0.6 due to some other dependencies. You can disregard my fork for the time being. I might pick it back up in a few weeks but unfortunately I don't have time to work on this atm. |
Finally have some time to start moving on this. On unix things look straight forward. I'm waiting for guidance from tokio-rs/mio#1460 |
Preliminary support for mio 0.7 has been added to the v4.0 branch |
I've tested the read_serialport example of the "v4.0_serialstream" branch under Windows and Linux and it works fine for me. |
Bump tokio 1.7.0 has just been released with support for Windows Named Pipes. This finally enables your v4.4.0_serialstream branch of tokio-serial to be finished for Windows, and thereby release an updated tokio-serial for tokio 1.x. But any work on tokio-serial requires this issue to be fixed first. |
I'll be using the https://github.com/berkowski/mio-serial/tree/v4.0_serialstream branch for Requires pinning branches/revisions in |
Started #25 as a roadmap to winding this up ahead of maintenance/transfer of ownership. |
version 4.0.0-beta1 is on crates.io with mio 0.7 support. |
I was about to fork and add support for mio 0.7. It's mostly a matter of switching from Evented to event::Source. However, @raffber has already done so in raffber/mio-serial. It would be great if his change could be pulled in and pushed to crates.io.
The text was updated successfully, but these errors were encountered: