Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beacon variant UI chromosome selector #226

Merged
merged 9 commits into from
Nov 22, 2024
Merged

Conversation

davidlougheed
Copy link
Member

@davidlougheed davidlougheed commented Nov 21, 2024

No description provided.

@davidlougheed davidlougheed requested a review from gsfk November 21, 2024 19:26
@davidlougheed
Copy link
Member Author

@gsfk not done yet for sure but requesting initial comments...

@davidlougheed
Copy link
Member Author

In the long term: https://redmine.c3g-app.sd4h.ca/issues/2409

@davidlougheed davidlougheed changed the title [WIP] Beacon variant UI chromosome selector Beacon variant UI chromosome selector Nov 22, 2024
@davidlougheed davidlougheed marked this pull request as ready for review November 22, 2024 16:21
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

For the next version can add gene name search and try to make the whole variants form a little more intuitive.

@davidlougheed davidlougheed merged commit e2e9b70 into main Nov 22, 2024
2 checks passed
@davidlougheed davidlougheed deleted the feat/beacon-chrom branch November 22, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants