Skip to content

Commit a3b8493

Browse files
committed
Remove rounding of slider velocity multiplier on juice streams
Compare: ppy#26616 This came up elsewhere, namely in ppy#28277 (comment). As it turns out, at least one beatmap among those whose scores had unexpected changes in total score, namely https://osu.ppy.sh/beatmapsets/971028#fruits/2062131, was using slider velocity multipliers that were not a multiple of 0.01 (the specific value used was 0.225x). This meant that due to the rounding applied to `SliderVelocityMultiplierBindable` via `Precision`, the raw value was being incorrectly rounded, resulting in incorrect conversion. The "direct" change that revealed this is most likely ppy/osu-framework#6249, by the virtue of shuffling the `BindableNumber` rounding code around and accidentally changing midpoint rounding semantics in the process. But it was not at fault here, as rounding was just as wrong before that change as after in this specific context.
1 parent 96af0e1 commit a3b8493

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

osu.Game.Rulesets.Catch/Objects/JuiceStream.cs

-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ public class JuiceStream : CatchHitObject, IHasPathWithRepeats, IHasSliderVeloci
2929

3030
public BindableNumber<double> SliderVelocityMultiplierBindable { get; } = new BindableDouble(1)
3131
{
32-
Precision = 0.01,
3332
MinValue = 0.1,
3433
MaxValue = 10
3534
};

0 commit comments

Comments
 (0)