Skip to content

Commit 9b2740f

Browse files
committed
Fix score submission test failures due to checking audio playback validity (again)
As seen in https://github.com/ppy/osu/actions/runs/7607899979/job/20716013982?pr=26662#step:5:75 In ppy#26484, I went "well if I'm moving the enabling of validation of playback rate to `SubmittingPlayer` context, then surely I can remove the local override in the test scene, right?" Reader: Apparently I did not notice that `FakeImportingPlayer : TestPlayer : SoloPlayer : SubmittingPlayer`. So no, I could not remove the local override in the test scene. You could probably attempt to conjure up some excuse about deep inheritance hierarchies here but nah. Really just a failure to read on my behalf as usual.
1 parent b7f0102 commit 9b2740f

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

osu.Game.Tests/Visual/Gameplay/TestScenePlayerScoreSubmission.cs

+6
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
using osu.Game.Rulesets.Taiko;
2424
using osu.Game.Rulesets.Taiko.Mods;
2525
using osu.Game.Scoring;
26+
using osu.Game.Screens.Play;
2627
using osu.Game.Screens.Ranking;
2728
using osu.Game.Tests.Beatmaps;
2829

@@ -383,6 +384,11 @@ public FakeImportingPlayer(bool allowPause = true, bool showResults = true, bool
383384
AllowImportCompletion = new SemaphoreSlim(1);
384385
}
385386

387+
protected override GameplayClockContainer CreateGameplayClockContainer(WorkingBeatmap beatmap, double gameplayStart) => new MasterGameplayClockContainer(beatmap, gameplayStart)
388+
{
389+
ShouldValidatePlaybackRate = false,
390+
};
391+
386392
protected override async Task ImportScore(Score score)
387393
{
388394
ScoreImportStarted = true;

0 commit comments

Comments
 (0)