Add support for removed swift fragment #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The swift fragment was removed at bazel HEAD and replaced by our custom starlark flag for copts in rules swift. This requires a version check that we're relying on bazel_features for if we want to be 100% accurate.
keith
requested review from
BalestraPatrick,
brentleyjones,
luispadron,
mattrobmattrob and
thii
as code owners
|
depends on bazel-contrib/bazel_features#36 |
luispadron
approved these changes
Jan 18, 2024
brentleyjones
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swift fragment was removed at bazel HEAD and replaced by our custom
starlark flag for copts in rules swift. This requires a version check
that we're relying on bazel_features for if we want to be 100% accurate.
Fixes #1148