Allow crate_universe modules to specify rust versions #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The downside of this approach is that the toolchains will be downloaded each time the module runs which is slower than the way it used to be with the downloads occurring in another repository and not getting invalidated if splicing needs to happen. This is absolutely not ideal and it'd be great if there was a way for users to easily specify the rust version and not need to download a bunch of stuff anytime a module is spliced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates bzlmod crate_universe to allow modules to specify the version of rust used for splicing. Previously
rust_host_toolsandrust_host_tools_nightlywere the only repositories available to consumers which both had fixed rust versions specified byrules_rust. This change gives users easy control of this value now.closes #3286