Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop six from third_party #23870

Closed
wants to merge 1 commit into from
Closed

Drop six from third_party #23870

wants to merge 1 commit into from

Conversation

aiuto
Copy link
Contributor

@aiuto aiuto commented Oct 4, 2024 •
edited
Loading

Drop six from third_party. We don't use it to build or test bazel. This potentially could break a user who depended on it from bazel_tools.

#18272 - part 1

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Oct 4, 2024
aiuto
aiuto commented Oct 4, 2024
View reviewed changes
@sgowroji sgowroji added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Oct 7, 2024
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 7, 2024
@meteorcloudy
Copy link
Member

We need to import the non-third_party change as a CL first. @aiuto Can you split that into a separate PR?

aiuto added a commit to aiuto/bazel that referenced this pull request Oct 8, 2024
@aiuto
Stop putting six in embedded tools.
d503406 
Unblocks: bazelbuild#23870
@aiuto aiuto mentioned this pull request Oct 8, 2024
Closed
@aiuto
Copy link
Contributor Author

aiuto commented Oct 8, 2024

Done #23896

@aiuto
Copy link
Contributor Author

aiuto commented Oct 8, 2024

This is now pure third_party.
I am not sure why the lock file is showing up. It is not changed.

copybara-service bot pushed a commit that referenced this pull request Oct 8, 2024
@meteorcloudy @copybara-github
Remove six from bazel's third party srcs target
756a0cb 
Follow up 7ec62e8

Working towards #23870

PiperOrigin-RevId: 683618985
Change-Id: I0a36dc6e2e029eca373f9142b44a7604f6eead9f
@iancha1992
Copy link
Member

iancha1992 commented Oct 8, 2024 •
edited
Loading

@aiuto Could you please squash all the commits into one, since this is third party changes? Also, the presumits are not passing. Is that okay?

@aiuto
Copy link
Contributor Author

aiuto commented Oct 9, 2024

Done. It's all rebased to one commit.

copybara-service bot pushed a commit that referenced this pull request Oct 9, 2024
@aiuto @iancha1992
Drop six from third_party
4f4f6a0 
Partial commit for third_party/*, see #23870.

Change-Id: I7ff47e721c30e4aaa7001915e3f8b214054ac14e
Signed-off-by: Hee Cha <heec@google.com>
@iancha1992
Copy link
Member

Merged at 4f4f6a0

@iancha1992 iancha1992 closed this Oct 9, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 9, 2024
@aiuto aiuto deleted the six branch October 9, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald left review comments

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aiuto @meteorcloudy @iancha1992 @Wyverald @sgowroji