Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling the user to request messages from remote execution #15336

Closed
exoson opened this issue Apr 25, 2022 · 3 comments
Closed

Enabling the user to request messages from remote execution #15336

exoson opened this issue Apr 25, 2022 · 3 comments
Assignees
Labels
P1 I'll work on this now. (Assignee required) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request

Comments

@exoson
Copy link
Contributor

exoson commented Apr 25, 2022

Description of the feature request:

Bazel gets RemoteExecuteResponses with a field messages when using remote execution: https://github.com/bazelbuild/remote-apis/blob/2af1c432ce11b01e46cf70d7933f71a3310282d6/build/bazel/remote/execution/v2/remote_execution.proto#L1376
Currently these messages are only printed for test actions when the test has failed. It would be great to be able to request bazel to unconditionally print those.

What underlying problem are you trying to solve with this feature?

Buildbarn sends paths to the action results and the action CAS entry through the messages interface. We would need some way of accessing this data unconditionally in the build event stream.

Which operating system are you running Bazel on?

N/A

What is the output of bazel info release?

N/A

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

N/A

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

N/A

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@ckolli5 ckolli5 added type: feature request untriaged team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Apr 25, 2022
@coeuvre
Copy link
Member

coeuvre commented Apr 27, 2022

I think these messages are printed for any actions that are failed. But since the protocol says the message should be also displayed when user requested explicitly, yes, Bazel should provide a way for user to request it.

@coeuvre coeuvre added P1 I'll work on this now. (Assignee required) and removed untriaged labels Apr 27, 2022
@exoson
Copy link
Contributor Author

exoson commented May 24, 2022

How about something like #15557

@exoson
Copy link
Contributor Author

exoson commented Jun 15, 2022

#15557 Fixed this. Closing

@exoson exoson closed this as completed Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants