Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --experimental_remote_cache_compression to be used as common option #14802

Closed
keith opened this issue Feb 12, 2022 · 4 comments
Closed
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request

Comments

@keith
Copy link
Member

keith commented Feb 12, 2022

If you'd like to always enable --experimental_remote_cache_compression it's natural to put it in your .bazelrc as:

common --experimental_remote_cache_compression

But this ends up breaking commands that don't support this flag:

% bazel help
INFO: Reading rc options for 'help' from .../.bazelrc:
  Inherited 'common' options: --experimental_remote_cache_compression
ERROR: --experimental_remote_cache_compression :: Unrecognized option: --experimental_remote_cache_compression

It would be great if this flag was ignored instead as others such as --experimental_downloader_config are.

What's the output of bazel info release?

release 5.0.0

@oquenchil oquenchil added team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request untriaged labels Feb 14, 2022
@coeuvre coeuvre added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Feb 21, 2022
@larsrc-google
Copy link
Contributor

Does this flag have any effect outside of build commands (and their derivatives like test etc)? If not, put it in your .bazelrc as build --experimental_remote_cache_compression.

@keith
Copy link
Member Author

keith commented Apr 4, 2022

It is mentioned in the docs that it's also compatible with query, although I'm not sure how much that matters, but I think practically for flags like this, there should be some consistent way users can say "apply this all the time!" without having to know exactly which commands it affects. I imagine most folks just throw everything under build, but that can be risky depending on the flag #10961

@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jun 14, 2023
@tjgq
Copy link
Contributor

tjgq commented Jun 14, 2023

I believe this has been addressed by #18130.

@github-actions github-actions bot removed the stale Issues or PRs that are stale (no activity for 30 days) label Jun 15, 2023
@coeuvre coeuvre closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request
Projects
None yet
Development

No branches or pull requests

5 participants