Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for gcc version 11 needed #13635

Closed
makingglitches opened this issue Jul 2, 2021 · 4 comments
Closed

Update for gcc version 11 needed #13635

makingglitches opened this issue Jul 2, 2021 · 4 comments

Comments

@makingglitches
Copy link

#13613

Code downloaded during build process com_google package requires either manual editing moving header references to header files if the symbols are being referenced or gcc 10 may need to be used

Adding a rule with preprocessing using symbol defines as part of compiler version detection during configuration could solve this but code edits would have to happen in any case

Also limits.h from stl needs to be changed to limits without extension in includes for stl

Suggested method is simply defining a symbol -DGCC11 which preprocessing could use to move the header file inclusions to the proper file

Where are the externs coming from is part of the information that needs provided as this might require some fixes across a few projects if they are not maintained in this one.

@makingglitches
Copy link
Author

Props to @neilg

May have discovered a broader issue than that in

#13613

@makingglitches
Copy link
Author

workaround exists according to:

#13613 (comment)
for some distros.
probably just a matter of running two parallel versions of gcc on fedora, which I don't feel personally is all that great an idea.

seems like it might carry with it some issues, would be better in my humble opinion just to make the edits as proscribed to detect the gcc version at configure-time and modify failing code files to respond to the idea mentioned above.

@davido
Copy link
Contributor

davido commented Jul 3, 2021

This is a duplicate of #12756.

Also note, that the problem is fixed with this PR: #13536, but it's blocked on #13561.

@makingglitches
Copy link
Author

@davido what is the source of the externs if you don't mind me asking ? Are they being maintained as some connected project ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants