Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing bzl_library declarations to satisfy client stardoc usage #33

Merged
merged 13 commits into from
Jan 27, 2024
Merged

fix: add missing bzl_library declarations to satisfy client stardoc usage #33

merged 13 commits into from
Jan 27, 2024

Conversation

cgrindel
Copy link
Member

  • Add missing bzl_library targets.
  • Add bzl_test to ensure that the targets in this repository are valid.

Closes #31.

@cgrindel cgrindel mentioned this pull request Jan 13, 2024
Closed
@cgrindel cgrindel marked this pull request as draft January 13, 2024 23:21
fmeum
fmeum reviewed Jan 14, 2024
View reviewed changes
@cgrindel cgrindel marked this pull request as ready for review January 14, 2024 21:16
@cgrindel cgrindel requested a review from fmeum January 15, 2024 15:33
fmeum
fmeum reviewed Jan 15, 2024
View reviewed changes
@cgrindel cgrindel requested a review from fmeum January 16, 2024 14:01
fmeum
fmeum reviewed Jan 27, 2024
View reviewed changes
@cgrindel cgrindel requested a review from fmeum January 27, 2024 15:21
fmeum
fmeum approved these changes Jan 27, 2024
View reviewed changes
@fmeum fmeum merged commit dd0effe into bazel-contrib:main Jan 27, 2024
5 checks passed
@cgrindel cgrindel deleted the debug_stardoc_error branch January 27, 2024 18:11
@cgrindel
Copy link
Member Author

@fmeum Thanks for reviewing. Could we create a new release with this fix?

@fmeum
Copy link
Member

fmeum commented Jan 27, 2024

I tried, but unfortunately we broke the BCR presubmit by introducing stardoc as a load dependency of the tests: bazelbuild/bazel-central-registry#1390
We should introduce a dedicated test module that uses the public bazel_features API and use that instead.

@cgrindel
Copy link
Member Author

cgrindel commented Jan 27, 2024 •
edited
Loading

Ok. I will take a look and put up a PR.

@alexeagle
Copy link
Contributor

ouch, it just keeps getting more complicated. I feel like the actual bug is that stardoc is so intolerant of symbols it cannot load.

@cgrindel
Copy link
Member Author

ouch, it just keeps getting more complicated. I feel like the actual bug is that stardoc is so intolerant of symbols it cannot load.

True. However, it is the only tool that actually confirms that your Starlark build graph is correct.

alexeagle added a commit to bazelbuild/rules_proto that referenced this pull request Apr 15, 2024
@alexeagle
chore: fix stardoc targets
c2110a0 
We need to pick up bazel-contrib/bazel_features#33
@alexeagle alexeagle mentioned this pull request Apr 15, 2024
Merged
comius pushed a commit to bazelbuild/rules_proto that referenced this pull request Apr 25, 2024
@alexeagle
chore: fix stardoc targets (#209)
d205d37 
https://github.com/bazelbuild/rules_proto/commits/main/ has been red
since Feb 12.

We need to pick up
bazel-contrib/bazel_features#33 to fix it.

Allows the 6.0.0 release to complete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickeylev rickeylev rickeylev left review comments

@fmeum fmeum fmeum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: bzl_library for bzl files
4 participants
@cgrindel @fmeum @alexeagle @rickeylev