Skip to content

Commit b2e4c2f

Browse files
committed
print more info in github requests errors
1 parent 338ce3c commit b2e4c2f

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

.toolbox.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ tools:
3838
github: hashicorp/terraform
3939
downloadURL: https://releases.hashicorp.com/terraform/{{ .VersionNum }}/terraform_{{ .VersionNum }}_{{ .OS }}_{{ .Arch }}.zip
4040
check: --version
41+
version: v1.8.5
4142
toolbox:
4243
github: bakito/toolbox
4344
check: --version

pkg/fetcher/fetch.go

+1
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ func (f *fetcher) Fetch(cfgFile string, selectedTools ...string) error {
118118
defer func() { _ = os.RemoveAll(tmp) }()
119119

120120
tools := tb.GetTools()
121+
println()
121122
for _, tool := range tools {
122123
if contains(selectedTools, tool.Name) {
123124
if err := f.handleTool(client, ver, tmp, tb, tool); err != nil {

pkg/github/client.go

+5-3
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,13 @@ func LatestRelease(client *resty.Client, repo string, quiet bool) (*types.Github
2727
SetError(ghErr).
2828
SetHeader("Accept", "application/json")
2929
handleGithubToken(ghc, quiet)
30-
resp, err := ghc.Get(latestReleaseURL(repo))
30+
url := latestReleaseURL(repo)
31+
resp, err := ghc.Get(url)
3132
if err != nil {
3233
return nil, http.CheckError(err)
3334
}
3435
if resp.IsError() {
35-
return nil, fmt.Errorf("github request was not successful: %s", ghErr.Message)
36+
return nil, fmt.Errorf("github request was not successful: %s (%d) %s", url, resp.StatusCode(), ghErr.Message)
3637
}
3738

3839
if ghr.TagName == "" {
@@ -76,12 +77,13 @@ func Release(client *resty.Client, repo string, version string, quiet bool) (*ty
7677

7778
handleGithubToken(ghc, quiet)
7879

80+
url := releaseURL(repo, version)
7981
resp, err := ghc.Get(releaseURL(repo, version))
8082
if err != nil {
8183
return nil, http.CheckError(err)
8284
}
8385
if resp.IsError() {
84-
return nil, fmt.Errorf("github request was not successful: %s", ghErr.Message)
86+
return nil, fmt.Errorf("github request was not successful: %s (%d) %s", url, resp.StatusCode(), ghErr.Message)
8587
}
8688

8789
if ghr.TagName == "" {

0 commit comments

Comments
 (0)