Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Layouts: add a "cancel" link in the layout reorder form #5936

Closed
klonos opened this issue Jan 15, 2023 · 4 comments · Fixed by backdrop/backdrop#4315
Closed

[UX] Layouts: add a "cancel" link in the layout reorder form #5936

klonos opened this issue Jan 15, 2023 · 4 comments · Fixed by backdrop/backdrop#4315

Comments

@klonos
Copy link
Member

klonos commented Jan 15, 2023

Steps to reproduce:

  1. add a couple of layouts with the same path (say node/%)
  2. head back to the layout management page
  3. there should be a "reorder" button -> click it
  4. change your mind -> no cancel link to go back 👎🏼 (I know there's always the browser back button, but having a "cancel" link is better UX)
@klonos
Copy link
Member Author

klonos commented Jan 16, 2023

PR: backdrop/backdrop#4315

@bugfolder
Copy link

Agreed that the cancel button is needed (and is currently lacking). Tested this PR: behold, the cancel button appears! WFM.

(Someday we'll have tabledrags directly on the layout page, obviating the need for a reorder button, but until that can be done, this is a good stopgap.)

Code reviewed. LGTM.

RTBC.

@klonos
Copy link
Member Author

klonos commented Oct 7, 2023

I've rebased in order to get the PR sandbox going again. All green except of cspell nagging, which should be fixed with #6255 - not here.

@quicksketch
Copy link
Member

Looks great! I merged backdrop/backdrop#4315 into 1.x and 1.26.x.

@klonos klonos removed their assignment Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants