Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Improve link text for menu settings #3635

Closed
jenlampton opened this issue Mar 29, 2019 · 4 comments · Fixed by backdrop/backdrop#2592
Closed

[UX] Improve link text for menu settings #3635

jenlampton opened this issue Mar 29, 2019 · 4 comments · Fixed by backdrop/backdrop#2592

Comments

@jenlampton
Copy link
Member

jenlampton commented Mar 29, 2019

On the admin page for menus, the drop-button for accessing the list of menu links reads Edit links. Since Edit isn't exactly the right choice here, I recommend changing this to Manage links instead.

What do people think? Is Edit providing value here, because this setting is saved in the database, or should we try to improve this language?

Screen Shot 2019-03-29 at 10 17 33 AM


PR: backdrop/backdrop#2592

@klonos
Copy link
Member

klonos commented Apr 2, 2019

I don't object to this, but perhaps reconsider things after implementing #475? ...or merge this request with that issue?

@TopperSaburo
Copy link

Great, although I do agree with @klonos about implementation of #475 before implementation of the manage links feature change. I definitely agree with you that manage links would be a more comprehensive feature description. 👍

@matthui
Copy link

matthui commented Apr 20, 2019

I tested it and the "manage links" works as expected.

@quicksketch
Copy link
Member

Thanks for the review @matthui and the PR @jenlampton! With no opposition and seeming an improvement, I've merged backdrop/backdrop#2592 into 1.x and 1.12.x, though it's likely to change again after #475 is implemented.

@matthui matthui removed their assignment May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants