Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout bids #970

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Timeout bids #970

merged 1 commit into from
Oct 27, 2022

Conversation

lukemarsden
Copy link
Contributor

@lukemarsden lukemarsden commented Oct 27, 2022 •
edited
Loading

To avoid holding open capacity forever in the case of lost messages/nodes etc.

binocarlos
binocarlos approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@binocarlos binocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukemarsden lukemarsden merged commit 9028956 into main Oct 27, 2022
@wjam wjam deleted the timeout-bids-avoid-holding-capacity-forever branch February 20, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binocarlos binocarlos binocarlos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukemarsden @binocarlos