Fix compute nodes stuck at bidding #921
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A compute node can bid on a job even after another bid was accepted and results were published, which will result in that compute node getting stuck in bidding state with capacity reserved as the requester node will ignore the bid and won't reject it. There are couple bugs that were fixed to mitigate this issue:
InvalidRequest
event back to the compute node if it bids on a job that is no longer biddable (e.g. completed or reached capacity), or if the job doesn't exist (e.g. requester node restarted)A long term solution is to implement timeouts in each state to let the compute node fail rather than getting stuck, if for example the requester node is no longer available. This is tracked in #663