Clean up usage of Name fields in job spec #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonwo
force-pushed
the
643-remove-names
branch
from
ff04750 to
9d1d186
Compare
These are legacy and no longer needed as we now understand how to correctly unmarshal enum types. Also, commands should return errors even when calling Fatal, so that the error condition can be probably caught during tests.
simonwo
force-pushed
the
643-remove-names
branch
from
9d1d186 to
24493f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are legacy and no longer needed as we now understand how to correctly unmarshal enum types.
Also, commands should return errors even when calling Fatal, so that the error condition can be probably caught during tests.
Resolves #643 and #645.