Remove cgo #870
Merged
Remove cgo #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have previously been using `wasmtime-go` to run our WASM executor which requires us to build using CGO for all platforms. This has proven to be problematic and has resulted in many yak shaves. There is also the downside that any project that uses bacalhau as a library now also has to use CGO. There is in fact a Go-only wasm engine called `wazero`. This commit moves us to using wazero instead. ����This is largely a painless process as the old and new libraries share a very similar API.
So long CGO, we hardly knew ye. We switched to using CGO in 3bf5e0. Since then we have seen a number of issues with it: - Builds have to be done on each platform rather than producing all of the builds from one box, because cross-compilation is badly supported between different OSes for C programs. - It produces dynamic builds by default and we would rather have static builds as they are easier to distribute. - It requires anyone using Bacalhau as a library to also build with CGO. Now that we have replaced our WASM engine to no longer require CGO, we can undo the CGO support and go back to building just with pure Go.
lukemarsden
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So long CGO, we hardly knew ye.
We switched to using CGO in
3bf5e0. Since then we have seen a number of issues with it:To do this, we've replaced our WASM engine with one that doesn't require CGO. It has some missing features compared to our existing implementation, but none that we are actually using. It is also better integrated with Go and should actually provide a more solid foundation from which to build.