624 publish on error #864
Merged
624 publish on error #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting the params of Wait - keep the existing function as is but trigger WaitWithOptions which uses the new options struct
|
ok (and thanks!) but what's the user experience of getting those logs? |
|
The test does basically the same as a |
|
We could at some point think about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we are actually publishing results to IPFS (or whatever the publisher is configured as) in the case of contianer exit code >= 1
I've added a test for this case and we also now have
WaitOptionswhich we can pass to the wait function so we can configure aspects of the wait function without bloating the input params