-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in docs #854
Closed
Closed
Fix typos in docs #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses bacalhau-project#707 - Improves naming for creating a stack - Better errors for bad executable and bad image - Fixed issue with running tests on the same machine you have custom ports - Disabling gocritic so it works with generics (for now) - Cleaning up marshaling for JobStates
* Still wait for a job to finish in the case that we set --id-only and --wait together, but otherwise silence the output * fixups
simonwo
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo fixes look good to me!
I've verified that if we rebase the josh/docs
branch on top of main
we will get just the docs fixes.
Your changes have been pushed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small changes as I familiarize myself with the Bacalhau codebase. It is possible I am missing some obvious details, so feedback is greatly appreciated!
Bacalhau is a very exciting project; thank you for the great docs and clean code.