Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in docs #854

Closed
wants to merge 11 commits into from
Closed

Fix typos in docs #854

wants to merge 11 commits into from

Conversation

joshklop
Copy link
Contributor

A few small changes as I familiarize myself with the Bacalhau codebase. It is possible I am missing some obvious details, so feedback is greatly appreciated!

Bacalhau is a very exciting project; thank you for the great docs and clean code.

aronchick and others added 11 commits October 10, 2022 08:15
Addresses bacalhau-project#707

- Improves naming for creating a stack
- Better errors for bad executable and bad image
- Fixed issue with running tests on the same machine you have custom ports
- Disabling gocritic so it works with generics (for now)
- Cleaning up marshaling for JobStates
* Still wait for a job to finish in the case that we set --id-only and --wait together, but otherwise silence the output

* fixups
Copy link
Contributor

@simonwo simonwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fixes look good to me!

I've verified that if we rebase the josh/docs branch on top of main we will get just the docs fixes.

@simonwo
Copy link
Contributor

simonwo commented Oct 13, 2022

Your changes have been pushed in 197954, thanks!

@simonwo simonwo closed this Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants