Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace node's jsonrpc servers with a rest api. #111

Merged
merged 5 commits into from
Jun 1, 2022
Merged

Conversation

Bubblyworld
Copy link
Contributor

See #97. Removes all of the JSONRPC client/server code and replaces it with
the publicapi package, which contains equivalent REST implementations. I've
fixed the READMEs and changed the --jsonrpc-host/port flags with
--api-host/post flags.

Copy link
Contributor

@binocarlos binocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (well excellent in fact) merge when ready

@Bubblyworld Bubblyworld merged commit b83f1fa into main Jun 1, 2022
@Bubblyworld Bubblyworld deleted the guy-http_server branch June 1, 2022 09:18
simonwo pushed a commit that referenced this pull request Dec 6, 2023
* update github workflows

* update docker image - remove outputs

* fix breaking changes on bacalhau docker image

* update breaking changes in pytorch file

* add text in pytorch file via bacalhau-project/examples@14d6322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants