feat: add new gatsby preset #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendriksoares
requested review from
jotanarciso,
MagnunAVFAzion,
enicio,
jcbsfilho and
tiagokrebs
as code owners
|
I think you should use the mountSSG hook and not mountSPA for Gatsby. Test your project locally with Vulcan Dev to be sure. |
|
Narciso feedback was done and tested locally. |
jotanarciso
changed the title
jotanarciso
previously approved these changes
Feb 15, 2024
maxwelbm
previously approved these changes
Feb 15, 2024
jcbsfilho
previously approved these changes
Feb 15, 2024
MagnunAVFAzion
requested changes
Feb 15, 2024
There was a problem hiding this comment.
We have a typo in some parts: gastby is used instead of gatsby
hendriksoares
dismissed stale reviews from jcbsfilho, maxwelbm, and jotanarciso
via
42885b5
MagnunAVFAzion
changed the title
MagnunAVFAzion
approved these changes
Feb 15, 2024
jcbsfilho
approved these changes
Feb 15, 2024
jotanarciso
approved these changes
Feb 15, 2024
tiagokrebs
pushed a commit
that referenced
this pull request
Feb 15, 2024
[skip ci] ## [2.4.0-stage.5](v2.4.0-stage.4...v2.4.0-stage.5) (2024-02-15) ### Features * add new gatsby preset ([#231](#231)) ([55e2bf5](55e2bf5))
|
🎉 This PR is included in version 2.4.0-stage.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tiagokrebs
pushed a commit
that referenced
this pull request
Feb 16, 2024
[skip ci] ## [2.4.0](v2.3.0...v2.4.0) (2024-02-16) ### Features * add hugo preset ([#192](#192)) ([a59b21a](a59b21a)) * add new gatsby preset ([#231](#231)) ([55e2bf5](55e2bf5)) * adding polyfill for Storage API for local server ([444ea38](444ea38)) * Nextjs routing and edge runtime ([#226](#226)) ([96b1788](96b1788)) * storage api local server ([#214](#214)) ([d793c90](d793c90)) ### Bug Fixes * bannerPlugin webpack injection bug fixed using bundler define ([8acdd5f](8acdd5f)) * bundlers compilation error ([#229](#229)) ([66f091a](66f091a)) * changing external dependencies in webpack as externalsType Module ([0339874](0339874)) * removing the requirement to useNodePolyfill when api external azion ([4b6cc2d](4b6cc2d))
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new preset to gastby. (mode deliver)