fix: validate installed dependencies only if they exists (#134)

Author: MagnunAVFAzion

lib/build/dispatcher/dispatcher.js

@@ -16,6 +16,7 @@ import {
   getAbsoluteLibDirPath,
   presets,
   getPackageManager,
+  getProjectJsonFile,
 } from '#utils';
 import { Messages } from '#constants';
 import { vulcan } from '#env';
@@ -24,16 +25,6 @@ const vulcanLibPath = getAbsoluteLibDirPath();
 const vulcanRootPath = resolve(vulcanLibPath, '..');
 const isWindows = process.platform === 'win32';
 
-/**
- * Get the path corresponding to a specific alias defined in the package.json.
- * @param {string} alias - The desired alias.
- * @returns {string} The path corresponding to the alias.
- */
-/**
- * Get the path corresponding to a specific alias defined in the package.json.
- * @param {string} alias - The desired alias.
- * @returns {string} The path corresponding to the alias.
- */
 /**
  * Get the path corresponding to a specific alias defined in the package.json.
  * @param {string} alias - The desired alias.
@@ -51,6 +42,7 @@ async function getAliasPath(alias) {
 
   return aliasPath;
 }
+
 /**
  * Move requires and imports to file init
  * @param {string} entryContent - The file content to be fixed.
@@ -200,6 +192,38 @@ async function folderExistsInProject(folder) {
   }
 }
 
+/**
+ * Check if node_modules dir exists
+ */
+async function checkNodeModulesDir() {
+  let projectJson;
+  try {
+    projectJson = getProjectJsonFile('package.json');
+  } catch (error) {
+    if (error.code === 'ENOENT') {
+      return;
+    }
+
+    feedback.prebuild.error(error);
+    process.exit(1);
+  }
+
+  if (
+    projectJson &&
+    (projectJson.dependencies || projectJson.devDependencies)
+  ) {
+    const pkgManager = await getPackageManager();
+    const existNodeModules = await folderExistsInProject('node_modules');
+
+    if (!existNodeModules) {
+      feedback.prebuild.error(
+        Messages.build.error.install_dependencies_failed(pkgManager),
+      );
+      process.exit(1);
+    }
+  }
+}
+
 /**
  * Class representing a Dispatcher for build operations.
  * @example
@@ -226,15 +250,8 @@ class Dispatcher {
    * Run the build process.
    */
   run = async () => {
-    // Check install depenedencies
-    const pckManager = await getPackageManager();
-    const existNodeModules = await folderExistsInProject('node_modules');
-    if (!existNodeModules) {
-      feedback.prebuild.error(
-        Messages.build.error.install_dependencies_failed(pckManager),
-      );
-      process.exit(1);
-    }
+    await checkNodeModulesDir();
+
     // Load Context based on preset
     const { entryContent, prebuild, config } = await loadBuildContext(
       this.preset,

lib/utils/getProjectJsonFile/getProjectJsonFile.utils.js

@@ -7,15 +7,11 @@ import { readFileSync } from 'fs';
  * @returns {object} - JSON object with file content.
  */
 function getProjectJsonFile(filePath) {
-  try {
-    const packageJsonPath = join(process.cwd(), filePath);
-    const packageJsonContent = readFileSync(packageJsonPath, 'utf8');
-    const packageJson = JSON.parse(packageJsonContent);
+  const packageJsonPath = join(process.cwd(), filePath);
+  const packageJsonContent = readFileSync(packageJsonPath, 'utf8');
+  const packageJson = JSON.parse(packageJsonContent);
 
-    return packageJson;
-  } catch (error) {
-    throw Error(`Error getting '${filePath}' file: ${error}`);
-  }
+  return packageJson;
 }
 
 export default getProjectJsonFile;