Added HIR database design doc. This is initial, and will change.

Author: waywardgeek

TODO

@@ -52,6 +52,7 @@ Support tuple unpacking.
 Support overloading modular operations, so we can support modular polynomials, etc.
 Add multi-threading support.
 Add schema-level reuse statements
+Write a schema generator for Rune similar to the dataview program for DataDraw schemas.
 Flush out generator's Rune code interpreter.
 Finish transition to memory pools, and allocation of global arrays with mmap of the memory available on the machine so large arrays never move.
 

bind/bind.c

@@ -542,7 +542,7 @@ void deBindAllSignatures(void) {
   deBinding binding = deRootGetFirstBinding(deTheRoot);
   while (binding != deBindingNull) {
     deRootRemoveBinding(deTheRoot, binding);
-    deBindStatement2(binding);
+    deBindStatement(binding);
     if (deBindingGetFirstExpression(binding) ==  deExpressionNull) {
       // The expression tree is now fully bound.
       deSignature signature = deBindingGetSignature(binding);
@@ -641,9 +641,14 @@ static void reportEvent(deEvent event) {
 // exit if any exist.
 void deReportEvents(void) {
   deEvent event;
-  deForeachRootEvent(deTheRoot, event) {
-    reportEvent(event);
-  } deEndRootEvent;
+  deSafeForeachRootEvent(deTheRoot, event) {
+    if (deEventGetFirstBinding(event) == deBindingNull) {
+      // This can happen if we destroy the statements that were blocked.
+      deEventDestroy(event);
+    } else {
+      reportEvent(event);
+    }
+  } deEndSafeRootEvent;
   if (deRootGetFirstEvent(deTheRoot) != deEventNull) {
     utExit("Exiting due to errors...");
   }

bind/bindexpr.c

@@ -1495,6 +1495,21 @@ static void refineAccessExpressionDatatype(deBlock scopeBlock, deExpression targ
   }
 }
 
+// Check the type constraint on the assignment expression.
+static void checkAssignmentTypeConstraint(deBlock scopeBlock, deExpression expression) {
+  deExpression access = deExpressionGetFirstExpression(expression);
+  deExpression value = deExpressionGetNextExpression(access);
+  deExpression constraint = deExpressionGetNextExpression(value);
+  if (constraint == deExpressionNull) {
+    return;
+  }
+  deDatatype datatype = deExpressionGetDatatype(value);
+  if (!deDatatypeMatchesTypeExpression(scopeBlock, datatype, constraint)) {
+    error(expression, "Violation of type constraint: %s",
+        deDatatypeGetDefaultValueString(datatype));
+  }
+}
+
 // Bind an assignment expression.
 static deBindRes bindAssignmentExpression(deBlock scopeBlock, deExpression expression) {
   deExpression access = deExpressionGetFirstExpression(expression);
@@ -1524,11 +1539,12 @@ static deBindRes bindAssignmentExpression(deBlock scopeBlock, deExpression expre
     refineAccessExpressionDatatype(scopeBlock, access, valueDatatype);
   }
   deExpressionSetDatatype(expression, valueDatatype);
+  checkAssignmentTypeConstraint(scopeBlock, expression);
   return DE_BINDRES_OK;
 }
 
 // Bind the array expression.
-static void bindArrayExpression(deBlock scopeBlock, deExpression expression) { 
+static void bindArrayExpression(deBlock scopeBlock, deExpression expression) {
   deLine line = deExpressionGetLine(expression);
   deExpression firstElement = deExpressionGetFirstExpression(expression);
   deDatatype datatype = deExpressionGetDatatype(firstElement);
@@ -2000,7 +2016,7 @@ static void rebuildBinding(deBinding binding) {
 }
 
 // Bind or continue expression the statement.
-void deBindStatement2(deBinding binding) {
+void deBindStatement(deBinding binding) {
   deExpression expression = deBindingGetFirstExpression(binding);
   deBlock scopeBlock = deGetBindingBlock(binding);
   while (expression != deExpressionNull) {
@@ -2045,6 +2061,6 @@ void deBindStatement2(deBinding binding) {
   }
   if (deBindingGetFirstExpression(binding) != deExpressionNull) {
     // We must have queued more expressions during post-processing.
-    deBindStatement2(binding);
+    deBindStatement(binding);
   }
 }

builtin/hashed.rn

@@ -210,7 +210,7 @@ generator Hashed(A: Class, B: Class, cascadeDelete: bool = false,
       }
     }
   } else {
-    appendcode A.destroy {
+    prependcode A.destroy {
       for x$labelB$B in range(self.$labelB$B_Table.length()) {
         $labelB$B_Entry = self.$labelB$B_Table[x$labelB$B]
         while !isnull($labelB$B_Entry) {
@@ -229,7 +229,7 @@ generator Hashed(A: Class, B: Class, cascadeDelete: bool = false,
     self.nextHashed$A$labelB$B = null(self)
   }
   // Remove self from A on destruction.
-  appendcode B.destroy {
+  prependcode B.destroy {
     if !isnull(self.$labelA$A) {
       self.$labelA$A!.remove$labelB$B(self)
     }

errortests/typeconstraint.rn

@@ -0,0 +1,15 @@
+//  Copyright 2023 Google LLC.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+a: i32 = 123u32